1
0
mirror of https://github.com/fwbuilder/fwbuilder synced 2026-03-18 17:27:20 +01:00

4395 Commits

Author SHA1 Message Date
Vadim Kurland
e8a87b16fb new build 3565 2011-07-19 19:46:21 -07:00
Vadim Kurland
83514e728b fixes #2566 Double-clicking on rule when program first starts results in empty editor pane 2011-07-19 19:41:27 -07:00
Vadim Kurland
e553360d24 see #2609 additional checks to make sure we do not allow drag and drop between different instances of the program 2011-07-19 19:35:54 -07:00
Vadim Kurland
d966ac1eb0 see #2564 added more negated icons 2011-07-19 19:15:01 -07:00
Vadim Kurland
a47d102c30 fixed SF bug 3371301 "Error compiling with VLAN and
masquerade". Iptables NAT rules with vlan interface configured as
"dynamic" and no ip address in Translated Source caused compiler
crash.
2011-07-19 19:07:56 -07:00
Vadim Kurland
739a76ffd0 see #2564 new "negated" icons 2011-07-19 18:26:56 -07:00
Theron Tock
2c70ef0583 * Fixed #2511: make sure auto-scroll of items in ObjectTreeView
works, otherwise it's impossible to move an item into a
	user-defined folder if there are lots of intervening items.
2011-07-18 15:05:10 -07:00
Vadim Kurland
08f1b604a5 ported fixes in AttachedNetworks from fortress 2011-07-17 17:06:04 -07:00
Vadim Kurland
bd096e893c fixed unit tests broken because of the recent changes 2011-07-13 18:57:47 -07:00
Vadim Kurland
df938198e7 new build 3564 2011-07-13 18:32:41 -07:00
Vadim Kurland
8fcb090760 applied patches by Vadim Zhukov persgray@gmail.com to unit tests 2011-07-13 18:24:16 -07:00
Theron Tock
48e1096c24 * Tried to fix #2507: set a size for the "type" column in the
dynamic group dialog (on some platforms it comes out so narrow you
	can't see it, despite it having ResizeToContents).
2011-07-13 16:59:30 -07:00
Theron Tock
8fb279a488 * Fixed #2523: save the expanded/collapsed state of the tree when
the user starts typing something into the quick filter.  When the
	quick filter is cleared, re-expand any items that started off
	expanded (so we get the union of expanded items displayed by quick
	filter plus what the user started with expanded).
2011-07-13 16:38:10 -07:00
Theron Tock
69bac5db2e * Fixed #2440. Now when a firewall is matched in the quick
filter, all child elements (e.g. policies, interfaces) will be
	displayed as well.
2011-07-13 15:36:45 -07:00
Theron Tock
6b8eaef07b Try #2 at fixing error checking. We still do want an error for the case
that the user forgets to set a data directory on a firewall and then
refers to it from an Address Table.  Made the error message a little
explicit since now the only way the error can happen is if the firewall
is missing the data directory setting.
2011-07-13 14:51:35 -07:00
Theron Tock
31357dc4d7 * Took out checks (added for #2514) for empty path in an Address
Table object.  It's valid to have an empty path for the situation
	where a user wants to use an ipset in place of the table.
2011-07-13 13:36:43 -07:00
Theron Tock
68f908b2ff Some cleanup to the fixes for #2505. 2011-07-13 13:07:24 -07:00
Theron Tock
dc32508caf * Fixed #2505: make sure that objects that we show are members of
a dynamic group are actually objects.  Previously we were showing
	stuff like FirewallOptions objects.  To make sure that dynamic
	group expansion is done the same way in the UI and for the
	compiler, also fixed #2502 (consolidate logic for DynamicGroup).
2011-07-13 12:09:36 -07:00
Theron Tock
095a7ee54b Fixes #2571 (build error with old qt) 2011-07-12 08:28:20 -07:00
Vadim Kurland
792a783612 see #2568 "Group name not preserved if group contains host object"; new build 3563 2011-07-11 23:18:17 -07:00
Theron Tock
c1216252c4 Merge branch 'development' of ssh://ncgit/var/git/fwbuilder into development
Conflicts:
	doc/ChangeLog
	src/pflib/CompilerDriver_pf_run.cpp
	src/pflib/TableFactory.cpp
	src/pflib/TableFactory.h
2011-07-11 21:52:31 -07:00
Theron Tock
4c4b67b5bd * Implemented #2514, support for address table alternate paths.
There's a "data directory" setting under user preferences.  If the
	user selects an address table file using "choose file" and that
	file is "inside" the data directory, then the appropriate part of
	the path is replaced with %DATADIR% as a variable.  If the address
	table is marked "run-time" then the path is taken from the
	firewall data directory option.
2011-07-11 21:33:13 -07:00
Vadim Kurland
d8387c4f75 new build 3562 2011-07-11 18:49:31 -07:00
Vadim Kurland
0790bb8509 see #2513 "Group and Address Table name persistence in generated
config". Compiler for PF can now preserve names of object groups,
dynamic groups, compile-time AddressTable and compile-time DNSName
objects in the generated pf.conf file. This is optional and is
controlled by a checkbox in the firewall settings dialog.
2011-07-11 18:43:29 -07:00
Vadim Kurland
b850545eab see #2551 Importer should parse PF rules that use "route-to",
"reply-to" and "dup-to" options in both pre-4.7 and 4.7 formats. In PF
4.7 these parameters moved to the end of the rule and are now part of
the "filteropts" block of parameters.
2011-07-09 21:41:04 -07:00
Vadim Kurland
8a8e9577fb see #2551 Importer should correctly import "pool type" parameter that
follows source routing rule options "route-to", "reply-to" and
"dup-to". Also, since currently fwbuilder does not support source
routing rules with multiple different interface-gateway pairs (only
one interface in combination with one or multiple gateway addresses
are supported), importer displays warning and marks rules as "broken"
when it encounters this configuration.
2011-07-09 21:30:54 -07:00
Vadim Kurland
bbf03ad49c see #2561 operation of making an interface a subinterface should be
performed using undo/redo command. Also, this should take care of
inconvenient scrolling of the object tree after this operation.
2011-07-09 16:42:37 -07:00
Vadim Kurland
433b845837 new build 3561 2011-07-09 14:42:46 -07:00
Vadim Kurland
7e2cdbb030 see #2562 "Crash when making an interface that has subinterfaces a
subinterface of another interfrace". If an interface has
subinterfaces, it should not be allowed to become subinterface of
another interface.
2011-07-09 14:33:00 -07:00
Vadim Kurland
0237f694d9 fixed yet another unit test that did not create FWObjectClipboard object and crashed because of that 2011-07-08 20:54:14 -07:00
Vadim Kurland
e4c31fa623 fixed broken unit tests 2011-07-08 19:12:50 -07:00
Vadim Kurland
8158519a06 see #2561 "Add context menu to move an interface to be a child of
another interface". New context menu (submenu) allows user to move an
interface in the tree to make it a subinterface of another interface.
2011-07-08 17:33:30 -07:00
Vadim Kurland
fac9d9caee fix bug in the PF importer: if a line ends with "$", lexer should put the "$" alone in the token stream as a single token 2011-07-08 13:54:26 -07:00
Vadim Kurland
48c33bb1f6 add standard comments to generated rules and objects in unit test 2011-07-08 12:22:19 -07:00
Vadim Kurland
8b9774a796 add standard comments to generated rules and objects in unit test 2011-07-08 12:21:12 -07:00
Vadim Kurland
57873de18d see #2556 "PF import: impor of rules referring to undefined
macros". Importer now records all parser errors in the comments of
rules where they occurred and marks these rules "broken" by coloring
them red. Behavior on import of pf.conf file with undefined macros is
inconsistent at this time: undefined macro that appears in a rule
where parser expects ip addresses is converted to a run-time DNSName
object with name "$macro", a warning is displayed and rule is marked
as "broken". Undefined macro in the position of interface name, port
name or other parameters triggers generic parser error that looks like
"Parser error: line 26:19: unexpected token: $ext". The rule is marked
as "broken" and the error is recorded in the comment.
2011-07-08 12:18:39 -07:00
Vadim Kurland
ea03c38e99 see #2556 "PF import:
impor of rules referring to undefined macros". Importer displays
warnings for all undefined macros found in the file, even if there
are several.
2011-07-08 11:45:42 -07:00
Vadim Kurland
a440400b9e fixes #2559 "Crash on import when at least one DynamicGroup object
already exists in the object tree."
2011-07-08 11:27:40 -07:00
Vadim Kurland
0a8bbd8be9 new build 3560 2011-07-08 11:01:12 -07:00
Vadim Kurland
cc9830d059 class ObjectSignature goes into its own .h .cpp files 2011-07-08 10:56:27 -07:00
Theron Tock
daf46cde28 Merge branch 'development' of ssh://ncgit/var/git/fwbuilder into development 2011-07-07 23:16:12 -07:00
Theron Tock
8451a78c49 Added rest of icons for dynamic groups.
Fixes #2544.
2011-07-07 23:15:18 -07:00
Vadim Kurland
fae60ec915 build 3559 2011-07-07 19:01:01 -07:00
Vadim Kurland
98593d3843 see #2191 "Crash when compiling a route with table object". Compiler
for PF crashed when run-time AddressTable object was used in RDst of a
routing rule.
2011-07-07 18:58:46 -07:00
Vadim Kurland
3cd58db242 fixes #2538 always use normal 64x64 icon for the editor dialog even if object is locked 2011-07-07 18:25:18 -07:00
Vadim Kurland
b3215ddafb see #2558 made the input field 300 pixels wide to be able to accommodate more than one ip address (which we do support btw) 2011-07-07 18:10:49 -07:00
Vadim Kurland
0d69945d2f see #2546 "PF import - negation inside of inline tables is
ignored". Since we can not import address lists or tables that contain
a mix of negated and non-negated items, importer should display an
error when it enounters one of these and mark all rules that use it as
"broken" (rule is colored red and error message is added to the
comment).
2011-07-07 18:04:24 -07:00
Vadim Kurland
56ee41fdee see #2556 "PF import: impor of rules referring to undefined
macros". If pf.conf file uses an undefined macro (there is $macro
somewhere but the macro has never been defined), importer issues a
warning, creates run-time DNSName object with the name "$macro" and
marks all rules where it is used as broken, that is, rules are colored
red and the error message is added to the comment field. Using
run-time DNSName object makes compiler use "$macro" in the generated
pf rule which means fwbuilder generates exactly the same pf rule as
the one it tried to import.
2011-07-07 17:24:57 -07:00
Vadim Kurland
d850139f2d see #2554 "PF import: create groups of address objects for macros
where possible". Importer for PF recognizes macros that define lists
of ip addresses, interfaces or host names and creates object groups
with the same name from them.  Only macros that contain at least one
ip address in the list are recognized.
2011-07-07 16:17:27 -07:00
Vadim Kurland
fff5775c39 new build 3558 2011-07-07 11:31:09 -07:00