1
0
mirror of https://github.com/fwbuilder/fwbuilder synced 2026-03-25 12:47:44 +01:00

1886 Commits

Author SHA1 Message Date
Vadim Kurland
927d21cb8f * InterfaceDialog.cpp (InterfaceDialog::validate): fixes #1221
warning dialogs for the incorrect interface name would not go
away.  If user entered incorrect name of the
subinterace (e.g. name that is not a valid VLAN subinterface name)
the GUI would pop up warning dialog infinitely.
2010-02-10 23:46:54 +00:00
Vadim Kurland
bd08467dde * ../src/gui/ProjectPanel_events.cpp (ProjectPanel::event): this
change attempts to fix a bug that causes main menu item Edit /
Paste (keyboard shortcut Ctrl-V) to stop working. The bug is hard
to reproduce and we were not able to find reliable scenario to
trigger it.
2010-02-10 22:46:03 +00:00
Vadim Kurland
c73c00658f * PolicyCompiler_ipt.cpp (specialCaseWithFWInDstAndOutbound::processNext):
fixes #1220 "bridging fw rule using all multicast object in
destination does not produce any iptables rules".
2010-02-10 22:10:44 +00:00
Vadim Kurland
9e3a3db7c7 proper check because of a crash that happened when user opened Deleted Objects library while some interfaces were there 2010-02-10 22:10:25 +00:00
Roman Bovsunivskiy
6713286942 Reusing old objects in FWBTree test 2010-02-09 18:53:19 +00:00
Roman Bovsunivskiy
781ee8ca6d Finished FWBTree::validateForInsertion test (Fixed #1024) 2010-02-09 18:49:48 +00:00
Vadim Kurland
bfb90b9324 * src/gui/ClusterGroupDialog.cpp (ClusterGroupDialog::applyChanges):
fixes #1215 "Edit protocol parameters" button gets disabled for no
reason. This button would get disabled after certain manipulations
in the cluster group object dialog even when no changes were made.
2010-02-07 21:12:36 +00:00
Vadim Kurland
d241ce0b9c * FWCmdChange.cpp (FWCmdChangeOptionsObject::notify): fixes #1212
Cluster object was not marked for recompile when user edited
conntrack group parameters
2010-02-07 17:48:12 +00:00
Vadim Kurland
a0314a7d97 * src/pflib/PolicyCompiler_pf_writers.cpp (PrintRule::processNext):
fixes #1210 "syntax error in PF rule - "modulate state" is
required".  Per bug reported in the mailing list (and according to
the pf.conf manual), pf.conf requires "keep state", "modulate
state" or "synproxy"if any of the stateful tracking options are
used in the rule. These include "max", "no-sync", "pflow",
"sloppy", "source-track" and others.
2010-02-07 05:24:21 +00:00
Vadim Kurland
8fae13fbd9 * src/pflib/PolicyCompiler_pf_writers.cpp (PrintRule::processNext):
fixes #1209 "incorrect syntax in PF rules when only "Activate
source tracking" option is on". Compiler sometimes generated empty
"( )" in the end of the pf.conf line when there were no state
tracking options
2010-02-07 05:05:33 +00:00
Vadim Kurland
e50fcd4beb * PolicyCompiler_ipt.cpp (PolicyCompiler_ipt::insertConntrackRule):
fixes #1175 "There is no option for unicast on conntrac
sync-group (like heartbeat)". User can now choose between multicast
and unicast for conntrackd communication.
2010-02-07 04:31:52 +00:00
Vadim Kurland
2506e35544 * FWWindow.cpp (FWWindow::showWelcome): fixes #1213 Welcome screen.
When user starts the program for the very first time, it shows
a "Welcome" screen that lists summary of features of fwbuilder and
provides a link to the Getting Started Guide on the web site. Link
to the local copy of Release Notes is also provided.
2010-02-07 02:47:03 +00:00
Vadim Kurland
62d10558d9 * linux24.xml, openwrt.xml: fixed #1172 It is ok for a cluster
interface with failover protocol heartbeat to have no ip address.
There are legitimate configurations where admin might want to run
heartbeat over an inetrface which itself has no virtual ip
address, for example to confine heartbeat packets to a dedicated
link.
2010-02-07 01:06:36 +00:00
Roman Bovsunivskiy
d076f6ff6c GUI unit tests now uses Xvfb (fixed #1211) 2010-02-06 12:07:24 +00:00
Roman Bovsunivskiy
41307f6aa7 Test for newClusterDialog 2010-02-05 17:38:41 +00:00
Vadim Kurland
dae933cf51 updated PIX screenshots in the release notes 2010-02-04 01:23:02 +00:00
Vadim Kurland
fc3621afc5 * FWObjectPropertiesFactory.cpp (FWObjectPropertiesFactory::getObjectPropertiesDetailed):
fixes #1201 "add parent to the object properties tooltip".
Include parent name in the tooltip that is shown for interface
objects.  This helps identify interfaces in rules, especially
subinterfaces and interfaces with common names in complex
configurations with many firewall objects.
2010-02-03 01:36:48 +00:00
Vadim Kurland
444fb52e8d * NATCompiler_ipt.cpp (ReplaceFirewallObjectsTSrc::processNext):
fixes #1200 "SNAT with cluster object in TSrc uses all
interfaces".  When a network or host address used in OSrc of a NAT
rule matches one of the interfaces of the firewall or a cluster,
there is not need to use this interface for the "-o" clause in
SNAT rule.
2010-02-03 01:20:24 +00:00
Vadim Kurland
312faac34b fixes #1207 2010-02-03 00:32:51 +00:00
Vadim Kurland
62e7dcc5e2 fixes #1205 2010-02-02 23:14:36 +00:00
Vadim Kurland
9a37f4855e refs #1204 2010-02-02 23:04:31 +00:00
Vadim Kurland
735cd46eee fixes #1203 added keyboard shortcut for "veiew object tree" menu item 2010-02-02 22:28:05 +00:00
Vadim Kurland
6df83ec139 * FWWindow.cpp (FWWindow::fileExit): fixes #1197 "clicking Cancel
in RCS log dialog cancels log but the program still exits".
2010-02-02 00:24:34 +00:00
Vadim Kurland
20d4f1323e * CompilerDriver.cpp (CompilerDriver::populateClusterElements):
see #1198. The check of subnets defined by the member and cluster
interfaces has been removed. The check originally implemented by
Secuwall developers looked only at the first address of the
interface and ignored others. It also did not allow for the
cluster interface netmask /32, which is the case with vrrpd. All
in all, the value here does not seem to be worth the effort of
implementing checks for all combinations.
2010-02-02 00:04:22 +00:00
Vadim Kurland
6efeea28ac * ../src/res/configlets/linux24/update_addresses: fixes #1196
"shell function update_addresses_of_interface() does not ignore
virtual addresses of cluster inetrfaces". When generated iptables
script updates ip addresses of interfaces, it should ignore
addresses managed by vrrpd, heartbeat or other failover daemons.
The script did not ignore them and instead removed them from
interfaces.
2010-02-01 23:44:42 +00:00
Vadim Kurland
79510f71e1 added english-only ts translation file 2010-02-01 22:34:43 +00:00
Vadim Kurland
976ab6c553 some more multicast groups 2010-02-01 21:56:16 +00:00
Vadim Kurland
591c5da521 * objects_init.xml: fixes #1194 "Add standard address objects for
various multicast groups". Added address objects for standard
multicast groups OSPF, RIP, EIGRP, DHCP server / relay agent, PIM,
RSVP-ENCAPSULATION, VRRP, IGMP, OSPFIGP-TE, HSRP, mDNS, Link-local
Multicast Name Resolution, Teredo.
2010-02-01 21:36:38 +00:00
Vadim Kurland
69a3a43f44 * ObjectManipulator.cpp (ObjectManipulator::updateCreateObjectMenu):
fixes #1195 the GUI should enable "new object" button and menu
item when objects_init.xml library is opened
2010-02-01 21:14:04 +00:00
Vadim Kurland
d88f1fddbc * platforms.cpp (isDefaultPolicyRuleOptions): fixes #1193 default
setting for "Assume fw is part of any" per-rule option is "follow
global"
2010-02-01 21:05:21 +00:00
Vadim Kurland
565155febc * ../src/res/os/linux24.xml: fixes #1192 "iptables script should
skip virtual addresses configured on cluster interfaces while
updating addresses of interfaces". The problem only affected
cluster interfaces with VRRP failover protocol.
2010-02-01 20:56:00 +00:00
Vadim Kurland
fbfd52444a * InterfaceEditorWidget.cpp (InterfaceEditorWidget::deleteAddress):
fixes #1191 "broken behavior in InterfaceEditorWidget". When user
added and then deleted bunch of ip addresses to an interface in
the new firewall or new cluster wizard, addresses below the
deleted row were ignored.

* InterfaceEditorWidget.cpp (InterfaceEditorWidget::deleteAddress):
fixes #1189 "GUI crash in newFirewall dialog upon completion".
GUI crashed in the new firewall wizard if user deleted an address
of an interface that had 3 or more addresses.
2010-02-01 20:30:05 +00:00
Vadim Kurland
35be1caa53 fixes #1185 "do not include member ip addresses for cluster NAT
policies". For NAT rules in a cluster, make it use only cluster ip
and ignore member ips.
2010-02-01 07:00:31 +00:00
Vadim Kurland
8f5f4b4f0e fixes #1187 regression in compiler for PIX 2010-02-01 06:39:24 +00:00
Vadim Kurland
945fa9191b * NATCompiler_ipt.cpp (AssignInterface::processNext): fixes #1184
"compiler/GUI crash compiling cluster NAT rule when cluster and
members have dynamic interface". It should be possible to have
cluster interface that is mapped to dynamic interfaces of the
member firewalls and then use this interface or whole cluster
object in rules. Compiler should expand cluster object and replace
it with its interfaces and corresponding interfaces of the member
firewall and then correctly handle dynamic ones.
2010-02-01 00:42:35 +00:00
Illya Yalovoy
0789f3c9b0 fixes #1164 focus moves in RuleSetView after paste 2010-01-31 22:46:05 +00:00
Illya Yalovoy
e44b0c727c refs #1141 Unusual selection behavior in RuleSetView
remove logging
2010-01-31 21:10:17 +00:00
Illya Yalovoy
700b95887a fixes #1182 rule number column is invisible when very first rule is created in a rule set 2010-01-31 21:09:25 +00:00
Illya Yalovoy
faad5cf2af refs #1141 Unusual selection behavior in RuleSetView
show current color group
2010-01-31 20:16:25 +00:00
Illya Yalovoy
811cc0df64 refs #1141 Unusual selection behavior in RuleSetView
added logging for events focusInEvent and focusOutEvent
2010-01-31 19:48:08 +00:00
Vadim Kurland
4dea1aca10 fixes #1173 2010-01-31 07:11:21 +00:00
Vadim Kurland
a99d955bec print rule position as part of debugging 2010-01-31 07:09:43 +00:00
Vadim Kurland
f120978fef * PolicyCompiler_ipt.cpp (checkInterfaceAgainstAddressFamily::processNext):
fixes #1172 "fwb_ipt does not generate rule for cluster interface
with no ip address".
2010-01-31 03:16:13 +00:00
Vadim Kurland
299ba93771 * OSConfigurator_linux24.cpp (OSConfigurator_linux24::processFirewallOptions):
fixes #1177 "problems with commands for conntrack_max, hashsize
and other advanced conntrack parameters". Needed to add a line
break between shell commands that set up kernel variables and
those that set up conntrack kernel variables.
2010-01-31 01:10:32 +00:00
Vadim Kurland
f06d8c3f22 * FWWindow.cpp (FWWindow::showSub): fixes #1181 "save state of
subwindow on maximize/restore". The GUI would revert to the
non-maximized subwindows display if user de-maximized subwindow,
then maximized it again and tried to open new data file.
2010-01-31 01:04:43 +00:00
Vadim Kurland
fbcd805a35 * ProjectPanel_file_ops.cpp (ProjectPanel::fileNew): fixes #1178
window title stays "[Untitled]" after File/new
2010-01-31 00:22:54 +00:00
Illya Yalovoy
1cf0eff780 fixes #1121 changing "rules font" in global preferences has no effect 2010-01-30 23:55:51 +00:00
Vadim Kurland
44c416a2ea * ../src/res/os/linux24.xml: fixes #1180 "heartbeat failover
protocol uses virtual ip address". New cluster wizard did not
allow the user to add ip address to cluster interface configured
with heartbeat failover protocol.
2010-01-30 23:49:59 +00:00
Illya Yalovoy
80e34753d2 fixes #1159 GUI crash on redo() 2010-01-30 22:00:08 +00:00
Vadim Kurland
91893e9d7b fix breakage with autorename 2010-01-30 20:22:49 +00:00