onkelbeh/fwbuilder
1
0
Fork 0
mirror of https://github.com/fwbuilder/fwbuilder synced 2026-09-16 09:59:37 +02:00
Code Issues Releases Wiki Activity
2,223 Commits 3 Branches 3 Tags
3cfd19c79b7df05bbffe31e11f31fe36451b8118
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Vadim Kurland 3cfd19c79b * PolicyCompiler_ipt.cpp (PolicyCompiler_ipt::checkForShadowingPlatformSpecific): 
see #1417 (SF bug 2992177) rule with greater limit module rate
value shadows rule with lower rate value. Comments in the code explain
why.
 2010-04-27 16:58:05 +00:00
Vadim Kurland ef2d783888 added comment to explain the logic behind shadowing detection with iptables limit modules 2010-04-27 16:15:20 +00:00
Vadim Kurland 29456bf2ea mention support for iptables modules limit, connlimit and hashlimit in shadowing detection 2010-04-27 00:58:47 +00:00
Vadim Kurland 4969dd185d mention support for OpenBSD 4.7 in release notes 2010-04-26 18:16:08 +00:00
Vadim Kurland 3a534ba839 fixes SF bug 2992177 linitation option hashlimitrate in gui 2010-04-26 16:32:58 +00:00
Vadim Kurland 72307e1bfa see #1417 (SF bug 2992177): compiler should compare 
limit rate value and other parameters set for modules limit, connlimit
and hashlimit while deciding if rules shadow each other.
 2010-04-26 16:27:57 +00:00
Vadim Kurland 6773503bdd fixes #1423 extend limits for "state limit" and "timeout adaptive scaling" for PF 2010-04-26 00:55:28 +00:00
Vadim Kurland b5044622f6 finally suppressed annoying debug prints FWCmdBasic::mergeWith 2010-04-26 00:41:00 +00:00
Vadim Kurland b9cfc1f5b8 * PolicyCompiler_ipt.cpp (PolicyCompiler_ipt::checkForShadowingPlatformSpecific): 
fixes #1417 rule shadowing detection should recognize different rule options.
Policy compiler for iptables takes into account rule options for modules
limit, connlimit and hashlimit when it considers rules for rule shadowing.
 2010-04-25 03:00:05 +00:00
Vadim Kurland 5f58d6bcf2 * instDialog.cpp (instDialog::show): fixed #1419: clear progress 
log display when instDialog is opened
 2010-04-25 01:54:41 +00:00
Vadim Kurland 3c420d0c92 see #1406 now definitely including installer log into unit test log on failure; using root account for testing, this only works when test can use ssh-agent authentication 2010-04-24 21:58:54 +00:00
Vadim Kurland 55ebd3a89c see #1406 add pause before an attempt to read installer progress log 2010-04-24 19:35:24 +00:00
Vadim Kurland 18a73c756e see #1406 include installer log in the test failure message when test fails 2010-04-24 18:58:09 +00:00
Vadim Kurland 3360977c2d * MangleTableCompiler_ipt.cpp (keepMangleTableRules::processNext): 
fixed #1415 "action branch that creates branch in mangle table
should branch in FORWARD chain". Rule with "any" in src and dst
and action Branch with option "branch in mangle table" will go
into FORWARD chain in addition to the PREROUTING and POSTROUTING
chains as before. Note that choice of PREROUTING or POSTROUTING
chains depends on direction.
 2010-04-24 01:41:47 +00:00
Vadim Kurland a23b39d61a added unit test for #1418 - test actually compiles a firewall, then tries to open instDialog again and makes sure the "compile" checkbox is now off 2010-04-24 00:29:25 +00:00
Vadim Kurland 614f5b094e * instDialog.cpp (instDialog::show): fixed #1418 "install 
checkboxes disappear from the compile/install dialog". This was a
regression introduced when we fixed #547 ("User can open multiple
compile/install dialogs")
 2010-04-24 00:02:46 +00:00
Vadim Kurland 9c0a3110b2 see #1418, #1089, #1153, #1405, #1381 moved one test to instDialogClusterTest where it belongs, implemented test for the "install" function that was missing, added tests for the hidden/visible column in the dialog and tests for the checkable columns 2010-04-23 22:27:03 +00:00
Vadim Kurland 647343fb62 see #1408 2010-04-23 21:27:47 +00:00
Vadim Kurland 4c6518d5d3 * PolicyCompiler_PrintRule.cpp (PrintRule::_printTarget): fixes #1416 
leading blank space in front of the custom action is missing.
SF bug 2991397.
 2010-04-23 18:22:08 +00:00
Vadim Kurland 433b8332a7 * NATCompiler_pf.cpp (VerifyRules::processNext): see #1401. Because 
of the change in the nat and rdr rules syntax in 4.7, I can no
longer implement no-nat rules correctly for this version. They
dropped the "no" keyword and their examples suggest using "pass"
to implement exclusions for the nat rules. I need no-nat rule to
just not translate but not make a decision whether the packet
should be passed or dropped. In the new PF model, translation
rules are just options on the matching policy rules and they do
not offer any keyword or option to not translate.
 2010-04-23 04:38:51 +00:00
Vadim Kurland fdb388659d * NATCompiler_pf_writers.cpp (PrintRule::processNext): fixes #1401 
nat rules syntax has changed in OpenBSD 4.7. Nat and rdr rules in
4.7 should be implemented using action "match" and keywords
"nat-to" and "rdr-to"

* PolicyCompiler_pf_writers.cpp (PrintRule::_printAction):
fixes #1414: use "match" action for tagging. Policy rules
with action Tag should use pf action "match" instead of "pass"
if version is 4.6 or later.
 2010-04-23 04:10:59 +00:00
Vadim Kurland 4d205e259f * PolicyCompiler_ipt.cpp (PolicyCompiler_ipt::insertFailoverRule): 
fixes #1411 "automatic rules for the HA protocol should match
source IP". Rules added for heartbeat in unicast mode already
matched source IP, this change makes rules added for VRRP, OpenAIS
and heartbeat in muticast mode also match source address.
 2010-04-20 23:10:46 +00:00
Vadim Kurland 3df762b301 * RoutingCompiler.cpp (reachableAddressInRGtw::checkReachableIPAddress): 
fixes #1410 "Problem with route for 4.0.0-b2809". Compiler did
not allow vlan subinterface as a gateway in a routing rule.
 2010-04-20 18:07:05 +00:00
Vadim Kurland b6a7824ff5 fixes #1409, SF bug 2985886. 
Depending on the combination of the activated options, shell
functions in the generated launcher script could have no body,
which is a syntax error in bash.
 2010-04-20 17:24:59 +00:00
Vadim Kurland c88c5d726b now run-tests.py deals with Xvfb instead of scripts inside fwbuilder module 2010-04-19 19:47:31 +00:00
Vadim Kurland f778743b89 use Xvfb only if env variable DISPLAY is not set 2010-04-19 17:54:39 +00:00
Vadim Kurland 6aa670d538 start and stop Xvfb for each unit test separately in an attempt to fight its constant crashes on Ubuntu intrepid 2010-04-19 17:22:07 +00:00
Vadim Kurland 92a8a0cf3e updated test case 2010-04-10 17:52:13 +00:00
Vadim Kurland 42a9419376 added test descriptions to the comment at the top of the module 2010-04-10 17:51:42 +00:00
Vadim Kurland f05f657700 * RoutingCompiler_ipt.cpp (RoutingCompiler_ipt::epilog): fixed #1404 
call to function restore_script_output in the generated iptables
script is sometimes added without function definition
 2010-04-09 21:29:29 +00:00
Vadim Kurland 33a1980b4d * NATCompiler_pf.cpp (ReplaceFirewallObjectsODst::processNext): 
fixes #1397   PF compiler fix: destination nat rule with fw object
in ODst should skip "on intf"
 2010-04-09 20:11:16 +00:00
Vadim Kurland 4f8eeb9b1f refs #1403, #1150 updated release notes 2010-04-09 19:50:58 +00:00
Vadim Kurland 4bbe1c2b12 * NATCompiler_ipt.cpp (AssignInterface::processNext): fixes #1403 
refs #1150  "Using ip address of wrong interface" is broken in v4.0.
 2010-04-09 19:50:03 +00:00
Vadim Kurland 8ceb3fd45f * ProjectPanel_state_ops.cpp (ProjectPanel::saveState): fixed #1402 
GUI crashes on exit when no rules are opened in the ruleset panel view
 2010-04-09 17:11:37 +00:00
Vadim Kurland 0417a1ba52 * ObjectTreeViewItem.cpp (ObjectTreeViewItem::data): fixed #1398 
bold font and "*" in the tree indicate firewalls that require
installation but should indicate those that require recompile
 2010-04-09 16:53:27 +00:00
Vadim Kurland dfdde2c857 * interfacePropertiesObjectFactory.cpp: fixed #1396, SF bug 2984193 
Vlan error when OpenWrt is selected as host
 2010-04-09 02:52:44 +00:00
Vadim Kurland c1708d457a fixes #1394 using existing virtual functions that expand multiple addresses to expand cluster interfaces. Now it is possible to use interface of a cluster different from the one being compiled in rules 2010-04-09 02:29:27 +00:00
Vadim Kurland 65a0f408a7 * ProjectPanel_file_ops.cpp (ProjectPanel::exportLibraryTest): 
fixed #1395 "routing rules are not reported properly while
exporting library"
 2010-04-08 22:53:47 +00:00
Vadim Kurland 1108d163b7 fixes #1389 added DD-WRT template firewall object 2010-04-08 19:02:54 +00:00
Vadim Kurland ee4710c062 * configlets/linux24/update_addresses: fixed #1391 "function 
getaddr_internal does not work with point-to-point interfaces".
 2010-04-08 18:51:00 +00:00
Vadim Kurland a4fc7dc8f3 fixes #1390 added ability to import iptables commands with both -i intf and -o intf. Added unit test as well 2010-04-08 01:51:45 +00:00
Vadim Kurland 8e46128a3e see #1390 * IPTImporter.cpp (IPTImporter::pushPolicyRule): see #1390 update 2010-04-08 01:00:59 +00:00
Vadim Kurland dbc94935f3 compiling debug prints for the problem reported by dmz@ conditionally 2010-04-07 23:34:17 +00:00
Vadim Kurland 4a41d7dbf0 debugging prints for dmz@ 2010-04-06 05:42:41 +00:00
Vadim Kurland 2e6eb87fe7 refs #1380 remove redundant configlet file 2010-04-01 22:32:05 +00:00
Vadim Kurland 684b44ce3d refs #1380 remove redundant configlet file 2010-04-01 22:31:34 +00:00
Vadim Kurland 96b19d1d58 fixes #1380 DD-WRT integration 2010-04-01 22:30:19 +00:00
Vadim Kurland 718768b849 disconnecting signal if startup dialog closes before http query completes 2010-04-01 17:53:04 +00:00
Vadim Kurland 159b8e796e * AddressRangeDialogTest.cpp (AddressRangeDialogTest::initTestCase): 
fixed #1366 - fixed unit test for AddressRangeDialog class
 2010-04-01 17:25:49 +00:00
Vadim Kurland 23a0cd7bc5 * RoutingCompiler_iosacl_writers.cpp (PrintRule::_printRItf): 
fixed #1379 "Should be able to build routing rules with interface
as gateway for IOS". Routing rules for IOS now have column
"Interface". Rules can be built either with explicit address of
the gateway or interface.
 2010-03-29 21:36:28 +00:00
Vadim Kurland 3cad647465 added test cases for #1377 and #1378; fixed #1378 see #1377 2010-03-29 20:38:31 +00:00
Vadim Kurland da08afa8c1 * PolicyCompiler_pf.cpp (PolicyCompiler_pf::compile): fixed #1375 
Interface group is not expanded in "Interface" rule element by
compiler for PF
 2010-03-29 20:01:10 +00:00
Vadim Kurland e7cf79af49 fixed #1374 Rule with group of interfaces in the "Interface" column is not compiled the same as when the same interfaces are placed there without group 2010-03-29 19:44:02 +00:00
Vadim Kurland e30c29ebd5 fixed #1370 2010-03-29 18:47:32 +00:00
Vadim Kurland 43cc4ebd10 see #1370 unit tests for configure_interfaces 2010-03-29 18:17:37 +00:00
Vadim Kurland bf361ab0b9 cloned CompilerDriver objects should inherit setting of the "embedded" flag 2010-03-29 18:07:03 +00:00
Vadim Kurland b85251e0e6 fixing unit test, see #1350 2010-03-29 03:10:02 +00:00
Vadim Kurland 279c56d14b * generatedScriptTestsLinux.cpp (GeneratedScriptTest::CheckUtilitiesTest): 
See #1370.  This is a place for the future compiler unit tests. In
the future we are going to migrate tests from test/ipt/ to this
directory, using cppunit framework and functions added to the
class Configlet per #1369
 2010-03-29 02:53:31 +00:00
Vadim Kurland c29a8b62b3 fixes in the debugging / unit testing famework See #1369 2010-03-29 02:40:02 +00:00
Vadim Kurland 7450fb2738 fixed #1369 2010-03-29 01:18:42 +00:00
Vadim Kurland 0f568c4fb8 * configlets/openbsd/installer_commands_reg_user: see #1368 A fix 
for the problem that causes built-in installer to hang after
updating configuration of PF firewalls.
 2010-03-28 21:06:35 +00:00
Vadim Kurland 3aec315ac0 fixed #1360 "negation of cluster interfaces is broken" 2010-03-27 21:41:04 +00:00
Vadim Kurland a6c0b0f1ee working on #1360 "negation of cluster interfaces is broken" 2010-03-27 20:39:20 +00:00
Vadim Kurland b5a794d1f1 * platforms.cpp (isDefaultPolicyRuleOptions): fixed #1365 "missing 
some flags for the "non-default" rule options for PF"

* FWObjectPropertiesFactory.cpp (FWObjectPropertiesFactory::getPolicyRuleOptions):
fixed #1364 "add synproxy and other missing pf rule options to the
rule options tooltip"
 2010-03-27 17:25:05 +00:00
Vadim Kurland f8d10ec3ff * RuleSetModel.cpp (RuleSetModel::getDecoration): fixed #1363 
"GUI crash in newClusterDialog". GUI crashed after a new cluster
object has been created from two PF firewalls.
 2010-03-27 02:13:01 +00:00
Vadim Kurland fc5e37d74d fixing other unit tests that broke because of addition of the module secuwallosAdvancedDialog 2010-03-27 01:34:08 +00:00
Vadim Kurland af842e864e fixing another unit test 2010-03-27 01:30:56 +00:00
Vadim Kurland a364bdc9b3 fixing unit test 2010-03-27 01:26:53 +00:00
Vadim Kurland 6c1213c9a5 * configlets/linux24/check_utilities: fixed #1359 "generated 
script hangs testing for iptables-restore"
 2010-03-26 17:55:22 +00:00
Vadim Kurland 99d385c09e * FWObjectPropertiesFactory.cpp (FWObjectPropertiesFactory::getObjectPropertiesBrief): 
fixed #1356 "Show number of rules in the rule set object in the
second column of the tree"
 2010-03-26 02:40:20 +00:00
Vadim Kurland 4c55060297 * PolicyCompiler_pf_writers.cpp (PrintRule::processNext): fixed #1351 
"synproxy rule option is broken"
 2010-03-25 16:44:30 +00:00
Vadim Kurland a6c8dec20a changelog records 2010-03-24 20:47:01 +00:00
Vadim Kurland dae8822e86 * using CppUnit::TestFixture in unit tests based on cppunit: 2010-03-24 03:07:54 +00:00
Vadim Kurland c9cf486720 * configlets/linux24/check_utilities: fixes #1348 "check_tools 
should check IPTABLES and IPTABLES_RESTORE as well"
 2010-03-23 21:04:27 +00:00
Vadim Kurland 85e0f16aa5 fixing unit test 2010-03-20 20:45:36 +00:00
Vadim Kurland 599ab65492 fixed SF bug 2973137 2010-03-20 00:17:28 +00:00
Vadim Kurland e308942369 fixed SF bug 2973221 "single rule compile (x) results in sigsegv". 2010-03-19 22:49:48 +00:00
Vadim Kurland 11d667ecf2 fixed #1347: ssh cancel rule install sigsegv SF bug 2973136 2010-03-19 22:46:53 +00:00
Vadim Kurland 6c5b8b3b32 fixed SourceForge bug 2973121: Added support 
for FWSM v4.x
 2010-03-19 22:33:23 +00:00
Vadim Kurland a25878ab6e fixed SourceForge bug 2973079 2010-03-19 21:58:25 +00:00
Vadim Kurland b8f059fcf1 * fixed SourceForge bug #2972699 "fwsm/pix syslog name". The dialog 
only accepts ip address for the syslog server.
 2010-03-19 04:20:03 +00:00
Vadim Kurland 23d5ab4370 * configlets/ipfw/script_skeleton: fixed #1335 "Empty functions in 
ipfw script". Under some circumstances shell functions in the
generated ipfw script could have no body; /bin/sh does not like
that.
 2010-03-19 03:15:09 +00:00
Vadim Kurland 5c67aa08f1 fixes #1340 
firewall object created from template does not inherit fw and host
os settings;  set "stateless rule " option in template rules
where it makes sense; turned ip forwarding and "assume fw is part
of any" in the "web server" template object.
 2010-03-18 21:24:55 +00:00
Vadim Kurland a0e953a5b8 tests for anti-spoofing rules when ip forwarding and "assume fw is part of any" are turned off. See #1338 2010-03-18 18:27:39 +00:00
Vadim Kurland c69b8f3188 more debugging for #1334 2010-03-16 19:04:04 +00:00
Vadim Kurland 8068056ae0 added a comment 2010-03-16 16:53:10 +00:00
Vadim Kurland 5764378004 renaming variable management_address see #1333 2010-03-15 23:05:17 +00:00
Vadim Kurland 365f9d9154 changelog record 2010-03-15 21:10:57 +00:00
Vadim Kurland 3169f643c5 * PolicyCompiler_PrintRule.cpp (PrintRule::_printOptionalGlobalRules): 
fixes #1333 "Add variable management_interface for the
automatic_rules configlet"
 2010-03-15 21:10:16 +00:00
Vadim Kurland fca8316205 changelog records 2010-03-15 16:07:40 +00:00
Vadim Kurland c1d8901854 * ObjectManipulator.cpp (ObjectManipulator::editSelectedObject): 
change in the behavior of double click in the tree.  Open rule set
object in the editor if it is already opened in RuleSetView. If we
just opened it in RuleSetView, check if the editor is visible and
if yes, open the object in the editor right away. Fixes #1331
 2010-03-15 16:05:34 +00:00
Vadim Kurland 6c06a6523d fixes #1326 MDI subwindow title is left "Untitled" when GUI starts with a file on the command line 2010-03-13 17:43:29 +00:00
Vadim Kurland 5a1aa6ceb3 using file name for the floating tree panel title. See #2714 2010-03-13 17:37:24 +00:00
Vadim Kurland 9671591ded fixes #1323 show startup tip after the file is loaded 2010-03-09 16:48:42 +00:00
Vadim Kurland 3eaa53a013 fixing unit tests 2010-03-08 01:51:24 +00:00
Vadim Kurland de012e8745 updated summary - removed link to the page with collection of getting started guides 2010-03-08 01:33:21 +00:00
Vadim Kurland 46566172a7 renaming welcome screen to summary of features and minor editing. Refs #1224 2010-03-08 01:25:39 +00:00
Vadim Kurland 7ba2fc1223 * renamed menu item Help/Welcome to Help/Summary of features. 
fixes #1311
 2010-03-08 01:13:19 +00:00
Vadim Kurland 02c45cb50d * FWWindow.cpp (FWWindow::startupLoad): final (hopefully) design 
of the welcome/startup window. Always showing startup tip dialog;
added buttons to show "Getting started" and "summary of features"
to the same dialog window. Fixes #1224
 2010-03-08 00:53:44 +00:00
Vadim Kurland 87bf5e3bf3 fixed gui crash because of the recent change that disabled mouse wheel scrolling in the MDI area tabs 2010-03-07 22:22:43 +00:00