Commit Graph
100 Commits
Author SHA1 Message Date
Vadim Kurland cb7662fdae see #2212 now compilers do not copy object database but CompilerDriver does. This means one object tree copy instead of many (it used to be one copy for the driver plus one copy for each compiler pass) 2011-03-12 14:49:12 -08:00
Vadim Kurland c9f8e8bf3e see #2209 changelog record 2011-03-11 12:30:29 -08:00
Vadim Kurland 1638eb4bd1 see #2207 finished fixes in all compilerts to enforce changes per #2209; regression tests for all platforms pass 2011-03-11 12:22:11 -08:00
Vadim Kurland db9584cab5 fixes #2214 2011-03-11 10:40:40 -08:00
Vadim Kurland 7ebdc6c238 see #2207, #2209, fixes #2213 all objects created by compilers are placed in persistent_objects library; CompilerDriver creates and manages persistent_objects lib; changes in libfwbuilder - an object can be a child of only one parent in the tree, method FWObject::add() enforces this and FWObject::findDuplicateLinks() can be used to find objects with multiple parents 2011-03-11 10:11:42 -08:00
Vadim Kurland 8d8cf4c9f2 * CustomServiceDialog.cpp (loadFWObject): fixes #2201 "Some fields
of locked object are editable". Some input fields of the Custom
Service object dialog were editable even when object was locked
read-only.
2011-03-08 19:12:37 -08:00
Vadim Kurland 3f10891723 * GroupObjectDialog.cpp (loadFWObject): fixes #2203 "Crash when
attempting to add an object to a locked group".
2011-03-08 19:07:28 -08:00
Vadim Kurland a1111b83bd * PolicyCompiler.cpp (checkForShadowing): see #2204 "Shadowing
detected for rule with action Continue". Policy rules with action
"Continue" should not shadow other rules and can not be shadowed.
2011-03-08 19:02:19 -08:00
Vadim Kurland de8921b32e * Importer.cpp (addStandardRuleComment): see #2189 Program adds
the file name and the line number to comments of policy and nat
rules it creates during import.
2011-03-08 18:15:57 -08:00
Vadim Kurland d60b82b47b updated unit test for iptables importer 2011-03-08 17:46:42 -08:00
Vadim Kurland f5e058fdd7 * IPTImporter.cpp (pushPolicyRule): see #2202 importer for
iptables creates Custom Service object to match combination of
states it does not recognize. This includes "NEW,ESTABLISHED".
2011-03-08 17:38:28 -08:00
Vadim Kurland 9ddcea553b see #2205 Crash when importing ASA configuration 2011-03-08 16:45:06 -08:00
Vadim Kurland 8fa729c028 see #2176, 2198 added button to register for updates about pf import 2011-03-08 16:35:06 -08:00
Vadim Kurland 676220c633 see #2176 better combination of refex to guess PF config; build 3498 2011-03-08 16:15:04 -08:00
Vadim Kurland ac257e0f43 build 3497 2011-03-07 18:55:34 -08:00
Vadim Kurland 9632d9b141 see #2197 "iptables nat rules in
chain OUTPUT not imported correctly"
2011-03-07 18:49:22 -08:00
Vadim Kurland 304fa20d24 * iptables.g (nat_addr_range): see #2194 "iptables import problem
with SNAT rule translating to an address range". NAT rules
translating into address range did not import correctly
2011-03-07 18:44:57 -08:00
Vadim Kurland 610448d440 * IPTImporter.cpp (pushNATRule): fixes #2195 "incorrect iptables
import of nat rule with NETMAP target"
2011-03-07 18:26:58 -08:00
Vadim Kurland a268a91f7b * IPTImporter.cpp (pushNATRule): see #2196 "iptables nat rules
with target REDIRECT not imported". Iptables NAT rules with target
REDIRECT where not imported correctly.

* IPTImporter.cpp (pushNATRule): see #2190 "support for import of
branches in NAT rules for iptables". Implemented import of NAT
rules in user-defined chains for iptables, these translate into
branching NAT rules in fwbuilder.
2011-03-07 18:21:04 -08:00
Vadim Kurland df3f79eb8c fixes #2192 import wizard size is set depending on the physical screen size; minor fix in snmp discoverer logging 2011-03-07 15:38:47 -08:00
Vadim Kurland 65f93be39d fixes #2193 import of pf.conf file, page 2 says "import of PF rules is not supported" but platform "iptables" 2011-03-07 15:14:22 -08:00
Vadim Kurland 0f4cdcad80 background image should transparent background 2011-03-07 15:08:51 -08:00
Vadim Kurland 522f268c8e updated fade-out background image 2011-03-07 15:02:12 -08:00
Vadim Kurland 8bf9c5fda3 added background image to the firewall import wizard; should be only visible on Mac 2011-03-07 14:55:45 -08:00
Vadim Kurland 85291843f5 * Importer.cpp (ignoreCurrentInterface): see #2152 "ASA Import -
shutdown interfaces". Importer recognizes and skips ASA interfaces
in "shutdown" mode.
2011-03-06 21:27:28 -08:00
Vadim Kurland 69d277ce41 see #2181 importr recognizes -i and -o 2011-03-06 20:14:47 -08:00
Vadim Kurland 2717d09f7e see #2170 checking combination of -i and -o interface and chain 2011-03-06 19:57:45 -08:00
Vadim Kurland 98a21d7248 build 3496; updated unit test files 2011-03-06 19:21:06 -08:00
Vadim Kurland 5c25bfb711 * IPTImporter.cpp (pushPolicyRule): see #2189 Policy importer
warnings and errors now include line numbers to help find relevant
lines in the original configuration file.
2011-03-06 13:16:11 -08:00
Vadim Kurland cac6101e0f fixes #2188 protocol "gre" could not be resolved to ip protocol number on Winbdows; implemented wrappers for getprotobyname() and getservbyname(), including protocol and tcp/udp service name resolution for cisco IOS and PIX; fixed unit tests for the importer 2011-03-06 12:47:20 -08:00
Vadim Kurland 9dbb444a51 fixes #2187 iptables parser error formatting problem 2011-03-05 23:49:47 -08:00
Vadim Kurland bc0b69ae71 fixes #2148 ASA Import - name of created firewall is hostname 2011-03-05 23:41:25 -08:00
Vadim Kurland 6a331a7642 bugfix: an error in regex list that should match pf.conf made it match all kinds of configs 2011-03-05 22:40:02 -08:00
Vadim Kurland a7dfe07409 see #2185 rearranged #include to make sure I include snmp.h only where it is really needed and always after all Qt headers 2011-03-05 21:33:53 -08:00
Vadim Kurland 9bf118bc12 trying to resolve build problem on windows "/usr/include/net-snmp/*" 2011-03-05 18:52:19 -08:00
Vadim Kurland 1100f1842a still trying to fix windows build 2011-03-05 16:04:09 -08:00
Vadim Kurland 7d962bb1ce see #2176 autodetect pf.conf format in importer 2011-03-05 15:55:46 -08:00
Vadim Kurland d82b81682e fixes #2183 count errors and warnings generated by the importer and show the numbers in the progress page of the wizard 2011-03-05 15:48:02 -08:00
Vadim Kurland 633b65f9d7 see #2174 warning for IOS, see #2175 warning for iptables 2011-03-05 15:38:20 -08:00
Vadim Kurland 538732c4ce fixes #2178 set platform and host os for FWSM; fixes #2156 After import the firewall should be opened in object tree 2011-03-05 15:32:53 -08:00
Vadim Kurland 4596a6cd53 fixes #2158 iptables import log is poorly formatted 2011-03-05 15:10:36 -08:00
Vadim Kurland 4b4febd253 fixes #2180 hitting Cancel while importer is working should not wait for it to complete 2011-03-05 14:54:07 -08:00
Vadim Kurland 85afa6dc8e see #2162 renamed menu item File / Import Firewall; see #2179 button Finish should be disabled while importer is still running 2011-03-05 11:06:22 -08:00
Vadim Kurland 834dd22e25 trying to fix windows build that got broken when I refactored snmp discovery into a separate wixard 2011-03-04 23:47:10 -08:00
Vadim Kurland 08265c5f0f minor clean up, removed unused function in Tools; trying to get rid of warnings about C4290 on windows; trying to fix windows build that got broken when I refactored snmp discovery into a separate wixard 2011-03-04 23:13:47 -08:00
Vadim Kurland 2e65d946da see #2161 import wizard finished 2011-03-04 18:06:54 -08:00
Vadim Kurland 0ed86de82a new policy import wizard; see #2161 - automatic detection of firewall platform and host name works 2011-03-04 13:34:45 -08:00
Vadim Kurland 0516ac43e5 build 3493 2011-03-03 21:59:55 -08:00
Vadim Kurland 56ad849d50 see #2163 creting objects discovered via snmp; snmp network discovery wizard is now functional 2011-03-03 21:55:10 -08:00
Vadim Kurland c21214c6a2 see #2163 passing data from the progress page to pages where user chooses networks and objects 2011-03-03 19:43:23 -08:00
Vadim Kurland 4b88c05cd6 see #2163 making sure crawler object is properly destroyed and recreated when user navigates back and forth within the wizard; also properly destroying the object after it is finished when user closes the wizard 2011-03-03 18:08:30 -08:00
Vadim Kurland 68a5bc7ef8 see #2163 pages that set up snmp crawler and crawler background process with progress log now work. Using QThread to run background process. 2011-03-03 14:05:28 -08:00
Vadim Kurland 2eed260387 see #2163 first page of snmp discovery wizard works (page "setup") 2011-03-02 21:29:45 -08:00
Vadim Kurland 3b2307b21c fixing build problems on windows, still messing around with -I 2011-03-01 21:47:50 -08:00
Vadim Kurland a164655216 fixing build problems on windows: added "-I .." to make #include work inside wizard subdirectories 2011-03-01 21:11:58 -08:00
Vadim Kurland 485a681bb0 fixing build problems on windows 2011-03-01 19:21:15 -08:00
Vadim Kurland 21fe9b7117 fixing build problems on windows 2011-03-01 18:56:12 -08:00
Vadim Kurland fd307f2320 added #include "ObjectDescriptor.h" 2011-03-01 18:01:46 -08:00
Vadim Kurland bea625d3b4 see #2163 remove #include "discoveryDruid.h" since it is not used anymore 2011-03-01 17:46:20 -08:00
Vadim Kurland a0eb7989ef build 3491 2011-03-01 17:20:44 -08:00
Vadim Kurland bebfd9fbff see #2163 code that imports addresses from a file in /etc/hosts format moved to its own wizard; using QWizard and QWizardPage classes with correct implementation of page sequencing and validation; old discovery druid has been disabled 2011-03-01 17:14:26 -08:00
Vadim Kurland 7e312722dc added test case for a group of hosts with mac addresses in a nat rule (SF bug should be opened later); re-ran tests 2011-02-27 22:37:16 -08:00
Vadim Kurland 19ce284f21 see #2156 select new firewall in tree, expand subtree and open firewall object in the editor after successful import 2011-02-27 13:30:22 -08:00
Vadim Kurland 30db079476 fixes #2159; also using macros for discovery druid page numbers 2011-02-27 12:54:08 -08:00
Vadim Kurland 689e54005d see #2160 "Installer reports error "Generated script file
<firewall>.fw not found."". The problem was intorduced earlier
while fixing #2047
2011-02-27 12:39:22 -08:00
Vadim Kurland 73500e15c5 see #2153 Wizard shows
additional page when user imports PIX/ASA config. This page
explains concept of network zones and offers UI to let them choose
network objects or groups as a network zone of each interface.
2011-02-26 20:45:57 -08:00
Vadim Kurland 849482d15d see #2153 added page with network zones explanation and widget; not functional yet but wizard navigates to it 2011-02-26 20:26:51 -08:00
Vadim Kurland ff53d6bd07 see #2145 Vlan interfaces discovered in the process of PIX configuration
import should be created as subinterfaces of the corresponding
parent with correct interface type and vlan id.
2011-02-26 12:17:23 -08:00
Vadim Kurland 1714e27233 see #2146 Issue a warning when
parser encounters "standby" parameter in an interface
configuration. We do not support import of PIX failover
configuration at this time.
2011-02-26 11:09:38 -08:00
Vadim Kurland 1258c4580e new build 3488; see #2147 "ASA Import - some versions are not detected correctly". SEtting version in the created firewall object to the best match of the version found in imported config 2011-02-26 10:45:40 -08:00
Vadim Kurland 59562d852c see #87 tested parser on pix6, pix7 and asa8 configs, making sure it parses different interface configurations correctly 2011-02-25 20:40:04 -08:00
Vadim Kurland dfb9983a7c see #87 fixed unit tests 2011-02-25 17:52:32 -08:00
Vadim Kurland 3f3a9030b9 see #87 changing explanation text in discovery druid page when user selects PIX; using #define to refer to import platform choices; better fix for the crash on open of discover druid (see #2144) 2011-02-25 17:34:15 -08:00
Vadim Kurland ef575257f1 Merge branch 'development' into pix_import 2011-02-25 17:15:11 -08:00
Vadim Kurland e0ac139d78 fixes #2144 GUI crash when user clicks "Import firewall configuration" shortcut button; new build 3487 2011-02-25 17:14:53 -08:00
Vadim Kurland db4d501ece see #87 import of interfaces for pix6,7 and 8 works. PArsing inetrface name, label, security level, address 2011-02-25 16:43:25 -08:00
Vadim Kurland e799b24496 see #87 minimal grammar, importer classes 2011-02-25 14:02:32 -08:00
Vadim Kurland c1eff2c7f9 renamed class AddressTableEditor to TextFileEditor 2011-02-24 11:16:54 -08:00
Vadim Kurland d841231a28 * AddressTableDialog.cpp (browse): see #2140 "Attempting to create
new Address Table file results in read-only error". Implemented
support for the workflow when user wants to create the file used
to feed addresses to the AddressTable object.
2011-02-24 11:10:52 -08:00
Vadim Kurland da776105be see #2139 show warning dialog and offer choice: open file for veiwing read-only or cancel 2011-02-24 10:19:46 -08:00
Vadim Kurland 25fa09d626 see #2135 Editing table objects 2011-02-23 19:28:22 -08:00
Vadim Kurland 222ff26e14 fixed unit test 2011-02-22 16:49:09 -08:00
Vadim Kurland 1aa38dc375 fixed unit test 2011-02-22 16:32:27 -08:00
Vadim Kurland e84751e95c see #2008 compiler avoids INPUT/OUTPUT chain if interface in the rule column "Interface" is a bridge port and firewall is bridging firewall (which means we are going to use --physdev-in or --physdev-out option for this rule) 2011-02-21 17:06:43 -08:00
Vadim Kurland 8ee59ebbf8 * newFirewallDialog.cpp (monitor): see #2126 Using snmp sysDescr
OID to guess version of the new firewall when it is created using
snmp polling.
2011-02-21 16:34:29 -08:00
Vadim Kurland cdbd1e35c3 see #1990 newly created PIX/ASA firewalls now have "generate outbound acl" option turned on by default 2011-02-21 15:11:47 -08:00
Vadim Kurland b42fe3e802 see #1678 When creating a firewall from template it appears that a default template is selected 2011-02-21 13:52:09 -08:00
Vadim Kurland cc509571f3 upgraded templartes.xml 2011-02-21 13:42:44 -08:00
Vadim Kurland 264d6bc3ee see #1971 dialog does not let user enter range end address lower than range start address 2011-02-21 13:35:13 -08:00
Vadim Kurland 0c1031aebf see #2085 modify platform name for Cisco IOS ACL 2011-02-21 13:21:41 -08:00
Vadim Kurland 886cfbea86 see #2113 removed unused function guessSecurityLevel (the second form that takes list of InterfaceData) 2011-02-21 13:21:17 -08:00
Vadim Kurland 49e79663a8 see #2113 looks like I need to support at least three patterns to cver different versions of PIX and ASA software. Moving routines that guess label and security level to platforms.cpp so I can use QString 2011-02-21 13:04:11 -08:00
Vadim Kurland f909d073eb see #2113 added pattern for ASA interface descriptions which is different from PIX interface descirptions 2011-02-21 12:20:21 -08:00
Vadim Kurland 966533a672 see #2113 added pattern for ASA interface descriptions which is different from PIX interface descirptions 2011-02-21 11:33:25 -08:00
Vadim Kurland 56f81407f1 fixes #2124 some error messages get multiplied when compiler splits rules 2011-02-20 21:32:58 -08:00
Vadim Kurland 2b342aa67d see #2057 detection of loops in branching rules ; see #2124 some error messages appeared multiple times in generated script 2011-02-20 20:12:18 -08:00
Vadim Kurland 344010c873 see #1920 Setting host interface to unnumbered after it has been assigned IP address doesnt have desired effect 2011-02-20 18:11:16 -08:00
Vadim Kurland e9e7f89cf2 see #1920 Setting host interface to unnumbered after it has been assigned IP address doesnt have desired effect 2011-02-20 18:03:21 -08:00
Vadim Kurland 37ab989922 see #1877 added test case for this 2011-02-20 17:45:46 -08:00
Vadim Kurland f817ddfe24 see #133 test case for SF feature request 1954286 2011-02-20 17:34:36 -08:00