1
0
mirror of https://github.com/fwbuilder/fwbuilder synced 2026-03-22 19:27:13 +01:00

3853 Commits

Author SHA1 Message Date
Vadim Kurland
0aa3eac4d4 * Compiler.cpp (expandGroupsInRuleElement): sorting objects in the
rule element by name after group is expanded, this helps ensure
stable ordering of objects in generated configuration.

* Compiler.cpp (replaceClusterInterfaceInItfRE::processNext):
sorting objects in rule element after cluster interfaces have been
replaced, this helps ensure stable ordering of objects in generated
configuration.

* FWObject.h (FWObjectNameCmpPredicate): moved this class from
gui-specific module to libfwbuilder as it is universally useful.
It can compare FWObject objects by name and can optionally can
follow references; it can be used with std::sort() to sort lists
of FWObject pointers or directly sort rule elements.
2011-03-12 19:50:24 -08:00
Vadim Kurland
424708006b see #2176 changed warning text and button label 2011-03-12 18:28:39 -08:00
Vadim Kurland
33070886db fixes #2219 when object is double clicked in rules to select it in the tree, the tree scrolls so that this object is at the top 2011-03-12 18:24:53 -08:00
Vadim Kurland
6b7d1f5806 fixes #2216 regression: system groups appear with user group icons and are editable 2011-03-12 18:20:23 -08:00
Vadim Kurland
821454988c fixed uninitialized variable 2011-03-12 18:07:40 -08:00
Vadim Kurland
4178c4e762 fixed dangerous memory access: the code used to delete object references instead of using removeRef() 2011-03-12 17:57:45 -08:00
Vadim Kurland
59d7fee4ad fixed dangerous memory access: the code used to delete object references instead of using removeRef() 2011-03-12 17:53:43 -08:00
Vadim Kurland
c4f6a5a219 fixed dangerous memory access: the code used to delete object references instead of using removeRef() 2011-03-12 17:49:50 -08:00
Vadim Kurland
26ab8d3e3e small memory leaks fixes in compiler for iptables 2011-03-12 17:35:29 -08:00
Vadim Kurland
393a53b64b see #2221 fixed memory leak: need to delete rule processors when compiler finishes 2011-03-12 16:57:20 -08:00
Vadim Kurland
5893edb768 see #2212 changelog record 2011-03-12 16:41:11 -08:00
Vadim Kurland
a1e48d58cd see #2220 removing old addMgmtRule method 2011-03-12 16:36:47 -08:00
Vadim Kurland
72f75c8f9b see #2220 AutomaticRuls classes for iosacl, pix, procurve_acl 2011-03-12 16:13:17 -08:00
Vadim Kurland
fd5eb7d8ce see #2220 AutomaticRules classes for ipt and pf 2011-03-12 15:52:09 -08:00
Vadim Kurland
fcd7c7920b re-ran tests for pix 2011-03-12 15:13:57 -08:00
Vadim Kurland
247d4efd61 commiting merge 2011-03-12 14:53:12 -08:00
Vadim Kurland
cb7662fdae see #2212 now compilers do not copy object database but CompilerDriver does. This means one object tree copy instead of many (it used to be one copy for the driver plus one copy for each compiler pass) 2011-03-12 14:49:12 -08:00
Vadim Kurland
d3bf44b4d5 re-ran tests for pix 2011-03-12 14:44:47 -08:00
Vadim Kurland
c9f8e8bf3e see #2209 changelog record 2011-03-11 12:30:29 -08:00
Vadim Kurland
1638eb4bd1 see #2207 finished fixes in all compilerts to enforce changes per #2209; regression tests for all platforms pass 2011-03-11 12:22:11 -08:00
Vadim Kurland
db9584cab5 fixes #2214 2011-03-11 10:40:40 -08:00
Vadim Kurland
7ebdc6c238 see #2207, #2209, fixes #2213 all objects created by compilers are placed in persistent_objects library; CompilerDriver creates and manages persistent_objects lib; changes in libfwbuilder - an object can be a child of only one parent in the tree, method FWObject::add() enforces this and FWObject::findDuplicateLinks() can be used to find objects with multiple parents 2011-03-11 10:11:42 -08:00
Vadim Kurland
2fa922d8b2 re-ran tests for ipfw 2011-03-11 09:19:03 -08:00
Vadim Kurland
9b4edad92f re-ran tests for ipf 2011-03-11 09:17:49 -08:00
Vadim Kurland
984a84ea2f Merge branch 'development' of ssh://vc.netcitadel.com:2222/var/git/fwbuilder into development 2011-03-10 21:10:11 -08:00
Vadim Kurland
7986214d4d re-ran pf tests and updated files 2011-03-10 21:09:54 -08:00
Vadim Kurland
8d8cf4c9f2 * CustomServiceDialog.cpp (loadFWObject): fixes #2201 "Some fields
of locked object are editable". Some input fields of the Custom
Service object dialog were editable even when object was locked
read-only.
2011-03-08 19:12:37 -08:00
Vadim Kurland
3f10891723 * GroupObjectDialog.cpp (loadFWObject): fixes #2203 "Crash when
attempting to add an object to a locked group".
2011-03-08 19:07:28 -08:00
Vadim Kurland
a1111b83bd * PolicyCompiler.cpp (checkForShadowing): see #2204 "Shadowing
detected for rule with action Continue". Policy rules with action
"Continue" should not shadow other rules and can not be shadowed.
2011-03-08 19:02:19 -08:00
Vadim Kurland
de8921b32e * Importer.cpp (addStandardRuleComment): see #2189 Program adds
the file name and the line number to comments of policy and nat
rules it creates during import.
2011-03-08 18:15:57 -08:00
Vadim Kurland
d60b82b47b updated unit test for iptables importer 2011-03-08 17:46:42 -08:00
Vadim Kurland
f5e058fdd7 * IPTImporter.cpp (pushPolicyRule): see #2202 importer for
iptables creates Custom Service object to match combination of
states it does not recognize. This includes "NEW,ESTABLISHED".
2011-03-08 17:38:28 -08:00
Vadim Kurland
9ddcea553b see #2205 Crash when importing ASA configuration 2011-03-08 16:45:06 -08:00
Vadim Kurland
8fa729c028 see #2176, 2198 added button to register for updates about pf import 2011-03-08 16:35:06 -08:00
Vadim Kurland
676220c633 see #2176 better combination of refex to guess PF config; build 3498 2011-03-08 16:15:04 -08:00
Vadim Kurland
ac257e0f43 build 3497 2011-03-07 18:55:34 -08:00
Vadim Kurland
9632d9b141 see #2197 "iptables nat rules in
chain OUTPUT not imported correctly"
2011-03-07 18:49:22 -08:00
Vadim Kurland
304fa20d24 * iptables.g (nat_addr_range): see #2194 "iptables import problem
with SNAT rule translating to an address range". NAT rules
translating into address range did not import correctly
2011-03-07 18:44:57 -08:00
Vadim Kurland
610448d440 * IPTImporter.cpp (pushNATRule): fixes #2195 "incorrect iptables
import of nat rule with NETMAP target"
2011-03-07 18:26:58 -08:00
Vadim Kurland
a268a91f7b * IPTImporter.cpp (pushNATRule): see #2196 "iptables nat rules
with target REDIRECT not imported". Iptables NAT rules with target
REDIRECT where not imported correctly.

* IPTImporter.cpp (pushNATRule): see #2190 "support for import of
branches in NAT rules for iptables". Implemented import of NAT
rules in user-defined chains for iptables, these translate into
branching NAT rules in fwbuilder.
2011-03-07 18:21:04 -08:00
Vadim Kurland
df3f79eb8c fixes #2192 import wizard size is set depending on the physical screen size; minor fix in snmp discoverer logging 2011-03-07 15:38:47 -08:00
Vadim Kurland
65f93be39d fixes #2193 import of pf.conf file, page 2 says "import of PF rules is not supported" but platform "iptables" 2011-03-07 15:14:22 -08:00
Vadim Kurland
0f4cdcad80 background image should transparent background 2011-03-07 15:08:51 -08:00
Vadim Kurland
522f268c8e updated fade-out background image 2011-03-07 15:02:12 -08:00
Vadim Kurland
8bf9c5fda3 added background image to the firewall import wizard; should be only visible on Mac 2011-03-07 14:55:45 -08:00
Vadim Kurland
85291843f5 * Importer.cpp (ignoreCurrentInterface): see #2152 "ASA Import -
shutdown interfaces". Importer recognizes and skips ASA interfaces
in "shutdown" mode.
2011-03-06 21:27:28 -08:00
Vadim Kurland
69d277ce41 see #2181 importr recognizes -i and -o 2011-03-06 20:14:47 -08:00
Vadim Kurland
2717d09f7e see #2170 checking combination of -i and -o interface and chain 2011-03-06 19:57:45 -08:00
Vadim Kurland
98a21d7248 build 3496; updated unit test files 2011-03-06 19:21:06 -08:00
Vadim Kurland
5c25bfb711 * IPTImporter.cpp (pushPolicyRule): see #2189 Policy importer
warnings and errors now include line numbers to help find relevant
lines in the original configuration file.
2011-03-06 13:16:11 -08:00