onkelbeh/fwbuilder
1
0
Fork 0
mirror of https://github.com/fwbuilder/fwbuilder synced 2026-03-21 18:57:14 +01:00
Code Issues Releases Wiki Activity

see #2084 we do not need to fetch routing tables while collecting interface data

Browse Source
This commit is contained in:
Vadim Kurland 2011-02-13 09:21:00 -08:00
parent da2c04e6f4
commit 4da7c66463
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/libfwbuilder/src/fwbuilder/snmp.cpp
View File

@ -1846,6 +1846,15 @@ void SNMP_interface_query::run_impl(Logger *logger,SyncFlag *stop_program) throw
{
fetchInterfaces(logger,stop_program);
#if 0
// See #2084 this takes forever on decides with large routing
// tables. Also it is unclear if routing table data is really
// used to determine external interface. Besides, we only have
// concept of external/internale on platforms that support
// security levels (PIX) and there we guess levels by matching
// addresses against RFC1918 and let the user user set levels
// manually anyway.
// We try to fetch routing table, to find
// which interface is "external".
// We do not fail if this query does not succeed.
@ -1856,6 +1865,7 @@ void SNMP_interface_query::run_impl(Logger *logger,SyncFlag *stop_program) throw
{
*logger << "Error fetching routing table, external interface will not be detected.\n";
}
#endif
}
void SNMP_sysdesc_query::run_impl(Logger *logger,SyncFlag *stop_program) throw(FWException)

6
src/libgui/newFirewallDialog.cpp
View File

@ -422,12 +422,12 @@ void newFirewallDialog::getInterfacesViaSNMP()
}
}
logger=NULL;
logger = NULL;
m_dialog->snmpProgress->clear();
if (q!=NULL) delete q;
q=new SNMP_interface_query();
q->init(addr.toString(),rcomm,SNMP_DEFAULT_RETRIES,SNMP_DEFAULT_TIMEOUT);
q = new SNMP_interface_query();
q->init(addr.toString(), rcomm, SNMP_DEFAULT_RETRIES, SNMP_DEFAULT_TIMEOUT);
timer->setSingleShot(false);
timer->start(0);