Ede_Vau
/
frr
mirror of https://github.com/FRRouting/frr.git
1
1
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #15476 from donaldsharp/dplane_thread_issue_i_believe 

zebra: fnc->obuf could be accessed without a lock
This commit is contained in:
Donatas Abraitis 2024-03-05 14:53:41 +02:00 committed by GitHub
parent a44918640f e7a1fbbcf6
commit fa5acd5a16
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
zebra/dplane_fpm_nl.c
View File

@ -1465,8 +1465,14 @@ static void fpm_process_queue(struct event *t)
uint64_t processed_contexts = 0;
while (true) {
size_t writeable_amount;
frr_with_mutex (&fnc->obuf_mutex) {
writeable_amount = STREAM_WRITEABLE(fnc->obuf);
}
/* No space available yet. */
if (STREAM_WRITEABLE(fnc->obuf) < NL_PKT_BUF_SIZE) {
if (writeable_amount < NL_PKT_BUF_SIZE) {
no_bufs = true;
break;
}