Commit Graph

Select branches

Hide Pull Requests

5.3

addressrange-ipv6

master

#1

#102

#103

#106

#114

#115

#116

#117

#118

#121

#121

#123

#123

#125

#125

#129

#129

#134

#134

#135

#135

#142

#142

#144

#144

#2

#22

#22

#3

#37

#38

#39

#42

#43

#43

#44

#45

#46

#48

#48

#51

#52

#53

#54

#57

#6

#63

#69

#71

#71

#75

#78

#79

#83

#87

#98

#98

#99

v5.3.7

v6.0.0-beta

v6.0.0-rc1

Mono Color

• 2c70ef0583 * Fixed #2511: make sure auto-scroll of items in ObjectTreeView works, otherwise it's impossible to move an item into a user-defined folder if there are lots of intervening items. Theron Tock 2011-07-18 15:05:10 -07:00
• 08f1b604a5 ported fixes in AttachedNetworks from fortress Vadim Kurland 2011-07-17 17:06:04 -07:00
• bd096e893c fixed unit tests broken because of the recent changes Vadim Kurland 2011-07-13 18:57:47 -07:00
• df938198e7 new build 3564 Vadim Kurland 2011-07-13 18:32:41 -07:00
• 8fcb090760 applied patches by Vadim Zhukov persgray@gmail.com to unit tests Vadim Kurland 2011-07-13 18:24:16 -07:00
• 48e1096c24 * Tried to fix #2507: set a size for the "type" column in the dynamic group dialog (on some platforms it comes out so narrow you can't see it, despite it having ResizeToContents). Theron Tock 2011-07-13 16:59:30 -07:00
• 8fb279a488 * Fixed #2523: save the expanded/collapsed state of the tree when the user starts typing something into the quick filter. When the quick filter is cleared, re-expand any items that started off expanded (so we get the union of expanded items displayed by quick filter plus what the user started with expanded). Theron Tock 2011-07-13 16:38:10 -07:00
• 69bac5db2e * Fixed #2440. Now when a firewall is matched in the quick filter, all child elements (e.g. policies, interfaces) will be displayed as well. Theron Tock 2011-07-13 15:36:45 -07:00
• 6b8eaef07b Try #2 at fixing error checking. We still do want an error for the case that the user forgets to set a data directory on a firewall and then refers to it from an Address Table. Made the error message a little explicit since now the only way the error can happen is if the firewall is missing the data directory setting. Theron Tock 2011-07-13 14:51:35 -07:00
• 31357dc4d7 * Took out checks (added for #2514) for empty path in an Address Table object. It's valid to have an empty path for the situation where a user wants to use an ipset in place of the table. Theron Tock 2011-07-13 13:36:43 -07:00
• 68f908b2ff Some cleanup to the fixes for #2505. Theron Tock 2011-07-13 13:07:24 -07:00
• dc32508caf * Fixed #2505: make sure that objects that we show are members of a dynamic group are actually objects. Previously we were showing stuff like FirewallOptions objects. To make sure that dynamic group expansion is done the same way in the UI and for the compiler, also fixed #2502 (consolidate logic for DynamicGroup). Theron Tock 2011-07-13 12:09:36 -07:00
• 095a7ee54b Fixes #2571 (build error with old qt) Theron Tock 2011-07-12 08:28:20 -07:00
• 792a783612 see #2568 "Group name not preserved if group contains host object"; new build 3563 Vadim Kurland 2011-07-11 23:18:17 -07:00
• c1216252c4 Merge branch 'development' of ssh://ncgit/var/git/fwbuilder into development Theron Tock 2011-07-11 21:52:31 -07:00
• 4c4b67b5bd * Implemented #2514, support for address table alternate paths. There's a "data directory" setting under user preferences. If the user selects an address table file using "choose file" and that file is "inside" the data directory, then the appropriate part of the path is replaced with %DATADIR% as a variable. If the address table is marked "run-time" then the path is taken from the firewall data directory option. Theron Tock 2011-07-11 21:33:13 -07:00
• d8387c4f75 new build 3562 Vadim Kurland 2011-07-11 18:49:31 -07:00
• 0790bb8509 see #2513 "Group and Address Table name persistence in generated config". Compiler for PF can now preserve names of object groups, dynamic groups, compile-time AddressTable and compile-time DNSName objects in the generated pf.conf file. This is optional and is controlled by a checkbox in the firewall settings dialog. Vadim Kurland 2011-07-11 18:43:29 -07:00
• b850545eab see #2551 Importer should parse PF rules that use "route-to", "reply-to" and "dup-to" options in both pre-4.7 and 4.7 formats. In PF 4.7 these parameters moved to the end of the rule and are now part of the "filteropts" block of parameters. Vadim Kurland 2011-07-09 21:41:04 -07:00
• 8a8e9577fb see #2551 Importer should correctly import "pool type" parameter that follows source routing rule options "route-to", "reply-to" and "dup-to". Also, since currently fwbuilder does not support source routing rules with multiple different interface-gateway pairs (only one interface in combination with one or multiple gateway addresses are supported), importer displays warning and marks rules as "broken" when it encounters this configuration. Vadim Kurland 2011-07-09 21:30:54 -07:00
• bbf03ad49c see #2561 operation of making an interface a subinterface should be performed using undo/redo command. Also, this should take care of inconvenient scrolling of the object tree after this operation. Vadim Kurland 2011-07-09 16:42:37 -07:00
• 433b845837 new build 3561 Vadim Kurland 2011-07-09 14:42:46 -07:00
• 7e2cdbb030 see #2562 "Crash when making an interface that has subinterfaces a subinterface of another interfrace". If an interface has subinterfaces, it should not be allowed to become subinterface of another interface. Vadim Kurland 2011-07-09 14:33:00 -07:00
• 0237f694d9 fixed yet another unit test that did not create FWObjectClipboard object and crashed because of that Vadim Kurland 2011-07-08 20:54:14 -07:00
• e4c31fa623 fixed broken unit tests Vadim Kurland 2011-07-08 19:12:50 -07:00
• 8158519a06 see #2561 "Add context menu to move an interface to be a child of another interface". New context menu (submenu) allows user to move an interface in the tree to make it a subinterface of another interface. Vadim Kurland 2011-07-08 17:33:30 -07:00
• fac9d9caee fix bug in the PF importer: if a line ends with "$", lexer should put the "$" alone in the token stream as a single token Vadim Kurland 2011-07-08 13:54:26 -07:00
• 48c33bb1f6 add standard comments to generated rules and objects in unit test Vadim Kurland 2011-07-08 12:22:19 -07:00
• 8b9774a796 add standard comments to generated rules and objects in unit test Vadim Kurland 2011-07-08 12:21:12 -07:00
• 57873de18d see #2556 "PF import: impor of rules referring to undefined macros". Importer now records all parser errors in the comments of rules where they occurred and marks these rules "broken" by coloring them red. Behavior on import of pf.conf file with undefined macros is inconsistent at this time: undefined macro that appears in a rule where parser expects ip addresses is converted to a run-time DNSName object with name "$macro", a warning is displayed and rule is marked as "broken". Undefined macro in the position of interface name, port name or other parameters triggers generic parser error that looks like "Parser error: line 26:19: unexpected token: $ext". The rule is marked as "broken" and the error is recorded in the comment. Vadim Kurland 2011-07-08 12:18:39 -07:00
• ea03c38e99 see #2556 "PF import: impor of rules referring to undefined macros". Importer displays warnings for all undefined macros found in the file, even if there are several. Vadim Kurland 2011-07-08 11:45:42 -07:00
• a440400b9e fixes #2559 "Crash on import when at least one DynamicGroup object already exists in the object tree." Vadim Kurland 2011-07-08 11:27:40 -07:00
• 0a8bbd8be9 new build 3560 Vadim Kurland 2011-07-08 11:01:12 -07:00
• cc9830d059 class ObjectSignature goes into its own .h .cpp files Vadim Kurland 2011-07-08 10:56:27 -07:00
• daf46cde28 Merge branch 'development' of ssh://ncgit/var/git/fwbuilder into development Theron Tock 2011-07-07 23:16:12 -07:00
• 8451a78c49 Added rest of icons for dynamic groups. Fixes #2544. Theron Tock 2011-07-07 23:15:18 -07:00
• fae60ec915 build 3559 Vadim Kurland 2011-07-07 19:01:01 -07:00
• 98593d3843 see #2191 "Crash when compiling a route with table object". Compiler for PF crashed when run-time AddressTable object was used in RDst of a routing rule. Vadim Kurland 2011-07-07 18:58:46 -07:00
• 3cd58db242 fixes #2538 always use normal 64x64 icon for the editor dialog even if object is locked Vadim Kurland 2011-07-07 18:25:18 -07:00
• b3215ddafb see #2558 made the input field 300 pixels wide to be able to accommodate more than one ip address (which we do support btw) Vadim Kurland 2011-07-07 18:10:49 -07:00
• 0d69945d2f see #2546 "PF import - negation inside of inline tables is ignored". Since we can not import address lists or tables that contain a mix of negated and non-negated items, importer should display an error when it enounters one of these and mark all rules that use it as "broken" (rule is colored red and error message is added to the comment). Vadim Kurland 2011-07-07 18:04:24 -07:00
• 56ee41fdee see #2556 "PF import: impor of rules referring to undefined macros". If pf.conf file uses an undefined macro (there is $macro somewhere but the macro has never been defined), importer issues a warning, creates run-time DNSName object with the name "$macro" and marks all rules where it is used as broken, that is, rules are colored red and the error message is added to the comment field. Using run-time DNSName object makes compiler use "$macro" in the generated pf rule which means fwbuilder generates exactly the same pf rule as the one it tried to import. Vadim Kurland 2011-07-07 17:24:57 -07:00
• d850139f2d see #2554 "PF import: create groups of address objects for macros where possible". Importer for PF recognizes macros that define lists of ip addresses, interfaces or host names and creates object groups with the same name from them. Only macros that contain at least one ip address in the list are recognized. Vadim Kurland 2011-07-07 16:17:27 -07:00
• fff5775c39 new build 3558 Vadim Kurland 2011-07-07 11:31:09 -07:00
• 5544cd94d4 check if a macro used somewhere in the file to be imported is actually defined and abort if not Vadim Kurland 2011-07-07 11:16:48 -07:00
• c4000fc0a2 set the flag to make importer add standard comments to rules and objects in unit test Vadim Kurland 2011-07-07 11:16:16 -07:00
• 6f842f1b99 see #2551 making sure rules that have route-to option get the call to setRoute() in the importer Vadim Kurland 2011-07-07 11:04:45 -07:00
• d98250b272 correct way to deal with object clipboard in unit tests; another patch from persgray@gmail.com Vadim Kurland 2011-07-06 18:42:14 -07:00
• 758e96a7bb need to create clipboard object for unit tests Vadim Kurland 2011-07-06 18:34:14 -07:00
• bde7cd1043 clear option "prolog_place" in compiler for iosacl to make sure function CompilerDriver::assembleFwScriptInternal() does not get confused if user switched fw platform Vadim Kurland 2011-07-06 18:06:11 -07:00
• bc490dad17 another patch from persgray@gmail.com, making commandLinePrintingTest run on both Linux and BSD Vadim Kurland 2011-07-06 17:35:05 -07:00
• e0be917ef2 * applied two patches by Vadim Zhukov persgray@gmail.com to replace calls to sprintf with safer calls to snprintf and fix some compiler warnings. Vadim Kurland 2011-07-06 16:43:38 -07:00
• 6046524a37 see #2552 "PF import: add ability to suppress comments referring to line numbers in the original file". Vadim Kurland 2011-07-06 16:13:59 -07:00
• af95604f75 Merge branch 'development' of ssh://vc.netcitadel.com:2222/var/git/fwbuilder into development Vadim Kurland 2011-07-06 14:37:24 -07:00
• fd63078a5e see #2551 "PF Import - source routing rules are not imported with rule options set". Importer should import "route-to" rule parameters. Vadim Kurland 2011-07-06 14:36:47 -07:00
• e241f452d3 Merge branch 'development' of ssh://ncgit/var/git/fwbuilder into development Theron Tock 2011-07-06 14:07:02 -07:00
• 2bcad481d9 More files that use QFileDialog::getOpenFileName(). Theron Tock 2011-07-06 14:05:07 -07:00
• aea0e07d28 new build 3557 Vadim Kurland 2011-07-06 14:00:54 -07:00
• 2914c7f81a * PFImporter.cpp (newAddressTableObject): see #2546 "PF import - negation inside of inline tables is ignored". We can not import PF table definition that has some addresses negated. Vadim Kurland 2011-07-06 12:45:16 -07:00
• f45f9ccb4b * PFImporterRun.cpp (run): see #2550 "PF import - recursive macros are not supported". Importer for PF should interpret macro definitions that use other macros. See #2545 "PF import error when using macro names with same base name and incrementing digit suffix". Importer should correctly interpret a macro that has name of another macro as a substring of its own name. Vadim Kurland 2011-07-06 12:14:06 -07:00
• 0f7f4ed790 added right test files and re-ran tests for PF Vadim Kurland 2011-07-05 18:06:35 -07:00
• 021cadf062 better behavior of FWObjectTypedChildIterator::operator--(); deleted test file that should have been recycled but wasnt Vadim Kurland 2011-07-05 18:00:48 -07:00
• 531c5a83fe PolicyCompiler_pf_writers.cpp (processNext): see #2549 "Update generated route-to configuration for PF versions 4.7 and later", SF bug 3348931. The "route-to" parameter moved to the end of pass rules in PF 4.7 Vadim Kurland 2011-07-05 14:00:35 -07:00
• f6628dcb38 new build 3556 Vadim Kurland 2011-07-05 13:31:36 -07:00
• eb67ae82ff * pf.g: fixed bug in PF import: address lists such as "{ addr1, addr2, ... }" defined as macros or inside the rule could not be imported correctly. Vadim Kurland 2011-07-05 13:27:14 -07:00
• 93e1664516 fixed AddressRangeDialogTest Vadim Kurland 2011-07-01 13:29:47 -07:00
• 7b38523f9f fixed CustomServiceDialogTest Vadim Kurland 2011-07-01 13:24:17 -07:00
• 93883953b5 upgraded .fwb files in all unit tests; fixed GroupObjectDialogTest Vadim Kurland 2011-07-01 13:02:00 -07:00
• 05e9a1e215 Made keyword add/remove buttons the same size. Fixes #2547. Theron Tock 2011-06-30 11:35:40 -07:00
• 54c16183e1 new build 3555 Vadim Kurland 2011-06-29 18:46:57 -07:00
• d7ee7ebabb Adding new icons for dynamic groups. Fixes #2544 partially. Theron Tock 2011-06-29 15:03:58 -07:00
• cad71437f3 Make sure user folders are added properly. Also deal with case of an object that has a folder attribute that doesn't exist in the parent's subfolders list (shouldn't ever happen, but in case it does it no longer crashes). Also make sure that subfolders don't have commas in them. Theron Tock 2011-06-29 14:50:07 -07:00
• 2ee4869fac Catch exception inside preprocessor loop so that loop continues after error (for unit tests). Also make sure to set ".loaded" variable before calling loadFromSource so that if an exception happens we won't try to load it again later. Theron Tock 2011-06-29 14:28:33 -07:00
• 57de77b341 On mac we can get a drop event even if dragMoveEvent() says the drop is invalid. So we validate the drop the same we validate in dragMove to make sure we don't crash on an invalid drop. Theron Tock 2011-06-29 12:58:55 -07:00
• 6a80bb8018 Removed dependency on fwtransfer that no longer exists. Theron Tock 2011-06-29 11:09:45 -07:00
• 1f420a97b0 new build 3554 Vadim Kurland 2011-06-27 17:57:56 -07:00
• 872fd64cb6 Various places in the code had logic for what directory to display in QFileDialog. There is now a single function to call, FWBSettings::getOpenFileDir() that will compute what directory to start in. Theron Tock 2011-06-27 16:51:21 -07:00
• 69364a4ee9 Display little folder icon next to "add subfolder". I don't see these icons on linux so hopefully this comes out looking right. :-) Theron Tock 2011-06-27 14:48:03 -07:00
• a82219e002 Recent changes. Theron Tock 2011-06-27 14:34:14 -07:00
• 64a8a7a9e2 Don't allow user to create duplicate subfolders. Theron Tock 2011-06-27 14:22:52 -07:00
• 780ae6b0af Don't open editor for system folder after adding/deleting user folder. Fixes #2530 Theron Tock 2011-06-27 13:32:40 -07:00
• 58f7142e4a Make it clear that cmp and shallowDuplicate are virtual. Fixes #2535 Theron Tock 2011-06-27 13:21:10 -07:00
• 4621f42319 Fix crash I introduced with undo/redo of user folders. Fixes #2529 Theron Tock 2011-06-27 12:22:35 -07:00
• 46a281a746 new build 3553 Vadim Kurland 2011-06-23 19:59:52 -07:00
• cac508c0e5 Fix for #2522. Theron Tock 2011-06-23 17:02:51 -07:00
• 240d4b5642 Merge branch 'development' of ssh://ncgit/var/git/fwbuilder into development Theron Tock 2011-06-23 16:41:50 -07:00
• 8c19f9f873 Make user-defined folders deletable even when they have something inside of them. Also make all user-defined folder operations support undo/redo. Theron Tock 2011-06-23 16:40:05 -07:00
• 26b349482c build 3552 Vadim Kurland 2011-06-22 16:19:02 -07:00
• 404e15f24e fixes #2485 added tooltips for tagging and classification rule options Vadim Kurland 2011-06-22 15:57:26 -07:00
• 5f93136e8f see #2518 renamed menu item Vadim Kurland 2011-06-22 15:41:34 -07:00
• ae21e6228f see #2520 "Attached Network objects are not renamed if a firewall is renamed" Vadim Kurland 2011-06-22 15:35:52 -07:00
• 510e6897dd upgraded test files Vadim Kurland 2011-06-22 15:28:48 -07:00
• d7a749154f see #2519 Avoid creating duplicate network objects for the AttachedNetwork object if the parent interface has multiple ip addresses that belong to the same subnet. Vadim Kurland 2011-06-22 15:25:18 -07:00
• c940bed072 see #2521 "Compile fails if firewall has locked interface that is set to dynamic". Vadim Kurland 2011-06-22 14:55:53 -07:00
• 344a22feed see #2524 'avoid " {tcp udp icmp} " in place of protocol'. NAT compiler for PF does not need to generate protocol match "proto {tcp udp icmp}" when service object used in the NAT rule is "any". The reason this was done this way is lost in the mist of time; it's been like this since very early versions of fwbuilder. Vadim Kurland 2011-06-22 11:03:07 -07:00
• 49eed4d5be fixes #2428 and SF bug 3305234; new build 3551 Vadim Kurland 2011-06-21 12:49:17 -07:00
• 201182a43d removed transfer agent file from the list in RPM .spec files Vadim Kurland 2011-06-20 22:25:55 -07:00
• 3d77e16144 QStringList::length() is avaoilable in Qt 4.5 and later, but Ubuntu Intrepid has older version without this function Vadim Kurland 2011-06-20 22:23:33 -07:00
• 70a5b9ac7c see #2508 function TCPUDPService::cmp should make sure object passed as a argument is of compatible type before using; this fixes the crash Vadim Kurland 2011-06-20 17:49:57 -07:00
• cebdfc5111 see #2500 object tree should have keyboard focus when new file is opened or new blank project window is created Vadim Kurland 2011-06-20 17:18:26 -07:00