1
0
mirror of https://github.com/fwbuilder/fwbuilder synced 2026-03-23 19:57:21 +01:00

622 Commits

Author SHA1 Message Date
Vadim Kurland
f01fdd206b * ProjectPanel_state_ops.cpp (ProjectPanel::loadState): refs #1236
Crash on Mac. The GUI could be crashed by repetetivie scrolling of
the tree and other parts of the main window with mouse scroll
wheel on Mac
2010-02-19 19:29:04 +00:00
Vadim Kurland
3e9383b8bd * FindObjectWidget.cpp (FindObjectWidget::_findAll): fixed #1256
search in the policy of firewalls does not work. This problem was
introduced whith a fix for #1250
2010-02-19 18:43:18 +00:00
Illya Yalovoy
8451718789 fixes #1244 GUI crash on exit
Looks like it is sufficient to just open some data file, open rule set 
	(I tried with Policy) and insert a rule in the middle. Then exist the 
	program and it crashes.
2010-02-19 11:08:56 +00:00
Vadim Kurland
c3db0a64f1 * PolicyCompiler_iosacl.cpp (splitTCPServiceWithFlags::processNext):
fixed #1247 incorrect use of tcp service with flags in
object-group.  "object-group service" does not seem to support tcp
flags and "established"
2010-02-19 04:33:13 +00:00
Vadim Kurland
81904f251f * ObjectTreeViewItem.cpp (ObjectTreeViewItem::data):
fixed #1248 Filtering in the object-tree crashes the GUI,
SourceForge bug #2954501
2010-02-19 04:05:40 +00:00
Vadim Kurland
bc438b831a * ObjectManipulator_tree_ops.cpp (ObjectManipulator::updateObjectInTree):
fixed #1249 GUI freezes when filters are applied. The GUI would
freeze for a few seconds every time user modified anything in rules
if a filter was applied to the tree at the same time.
SourceForge bug #2954501
2010-02-19 03:38:56 +00:00
Vadim Kurland
b38d8050d1 * ObjectManipulator.cpp (ObjectManipulator::contextMenuRequested):
fixed #1255 context menu items "Lock" and "Unlock" are not updated
after object is locked.
2010-02-19 03:06:25 +00:00
Vadim Kurland
0fa38387e1 * ProjectPanel_events.cpp (ProjectPanel::event): fixed #1253
Locking an object in the tree causes GUI crash.
2010-02-19 02:28:31 +00:00
Vadim Kurland
e7b6128f65 * FWWindow.cpp (FWWindow::FWWindow): fixed #1252 The "New
Object"-Dialog is always opened up twice when pressing <CTRL>+<N>
2010-02-19 01:05:59 +00:00
Vadim Kurland
236eb79758 changelog rec 2010-02-19 00:53:12 +00:00
Vadim Kurland
d6a02ae002 * FindObjectWidget.cpp (FindObjectWidget::_findAll): fixed #1250
The Find-Dialog searches "Deleted Objects-library although its
not enabled in the preferences.
2010-02-19 00:52:49 +00:00
Vadim Kurland
2006657ff6 * IPv4Dialog.cpp (IPv4Dialog::DNSlookup): fixed #1251 DNS-Lookups
in Address-Objects dont work. Sourceforge bug #2954501
2010-02-19 00:43:16 +00:00
Vadim Kurland
c4f4e5324b fixes #1241 implemented "add mirror rule" checkbox for IOSACL 2010-02-18 04:59:47 +00:00
Vadim Kurland
2412e87307 * ssh_wrappers.cpp (ssh_wrapper): fixed #1246 policy installer
fails on Linux. Policy installer failed with error "bash: -c: line
6: syntax error: unexpected end of file" while trying to activate
iptables script on Linux. This error was introduced in one of the
recent builds.
2010-02-18 01:59:21 +00:00
Vadim Kurland
f4b3662c02 * fixed #1243 "new cluster" operation creates failover groups that
recursively refer to the interfaces of the same cluster. This
happened when new cluster was created with a copy of rules from
one of the firewalls.
newClusterDialog_create.cpp
2010-02-17 06:19:12 +00:00
Vadim Kurland
17de7d3fe2 * fixes #1235 "cluster with dynamic interface can not be used in
rules". Fixes this and several other problems with policy and nat
rules that use cluster inetrfaces with dynamic addresses.
PolicyCompiler_ipt.cpp
NATCompiler_ipt.cpp
2010-02-17 05:37:55 +00:00
Vadim Kurland
a63382fe48 * NATCompiler_pf.cpp (NATCompiler_pf::assignInterfaceToNATRule):
fixes #1240 nat rule should get "on interface" when cluster
interface is used in TSrc.
2010-02-17 02:43:23 +00:00
Vadim Kurland
af51aea7a1 * ../src/compiler_lib/Configlet.cpp (Configlet::expand): added
basic protection against infinite loops in configlet expansion.
2010-02-16 15:40:13 +00:00
Vadim Kurland
a8404af984 * Added template for the OpenWRT firewall. Fixes #1237
removed unnecessary qDebug() printing
2010-02-16 04:59:08 +00:00
Vadim Kurland
fc06834646 changelog rec 2010-02-16 02:07:48 +00:00
Vadim Kurland
080bbfff5d * StartTipDialog.cpp (StartTipDialog): working on memory leaks
with the help of valgrind. Refs #1229
2010-02-16 02:06:37 +00:00
Illya Yalovoy
724d3e30de refs #1202 Main menu "Rules" does not match rule context menu 2010-02-15 22:38:20 +00:00
Vadim Kurland
fb538ed7cd refs #1229 memory leaks 2010-02-15 07:13:16 +00:00
Illya Yalovoy
098df9b7b7 fixes #1228 removing consecutive rules from a group in a ruleset 2010-02-14 22:12:48 +00:00
Vadim Kurland
09f29554c8 * PolicyCompiler_ipt.cpp (PolicyCompiler_ipt::_expand_interface):
fixes #1234 When failover group object is used in the rule, rule
gets placed in FORWARD chain. Working implementation follows these
rules: 1) if cluster interface obejct is used in the rule, it is
expanded to the set of addresses including cluster virtual IP
address and all addresses of the corresponding member firewall
interface; 2) Failover Group is treated as any regular object
group. Expanding Failover group to the address of its
parent (cluster interface) would work but seems counter-intuitive
2010-02-14 22:02:57 +00:00
Vadim Kurland
76dd6e285c * PolicyCompiler_ipt.cpp (decideOnChainIfDstFW::processNext):
fixes #1231 rules are placed FORWARD chain if firewall object is
"bridging firewall". This bugfix concerns specific rule
configuration used with bridging firewall where firewall object or
one of its interfaces is used in "destination" and an interface
which is not a bridge port is in the "interface" rule column. Rule
like this should go into INPUT chain but compiler used to splut it
and put generated iptables rules in both INPUT and FORWARD chains.
Rule should be placed in the FORWARD chain only if interface in
"interface" column is bridge port. The same algorithm also applies
to rules with firewall or one if its interfaces in the "Source"
column.
2010-02-14 18:54:47 +00:00
Vadim Kurland
4fa9d3fc41 * OSConfigurator_bsd.cpp (OSConfigurator_bsd::configureInterfaces):
New feature: incremental management of pfsync0 interface on
OpenBSD. The script checks if interface exists and if not, it runs
"ifconfig pfsync0 create" command to create it. If interface
exists, the script only runs ifconfig to configure its parameters
but does not try to create it again. If State Synchronization
group object is deleted in fwbuilder GUI, interface pfsync0 will
be deleted on the firewall by the script.
2010-02-14 07:08:12 +00:00
Vadim Kurland
6ad95727b1 sync vlan and carp interfaces even if there are none in fwbuilder objects 2010-02-14 06:25:29 +00:00
Vadim Kurland
d6d0dd0e41 * OSConfigurator_bsd.cpp (OSConfigurator_bsd::configureInterfaces):
New feature: generated script adds and removes CARP interfaces
incrementally. This means it is not going to run ifconfig command
to create carp interface if it is already there and will run
"ifconfig carp1 destroy" command if interface carp1 has been
removed in fwbuilder GUI to delete it on the firewall.
2010-02-14 06:16:44 +00:00
Vadim Kurland
81ee822cd3 * OSConfigurator_bsd.cpp (OSConfigurator_bsd::configureInterfaces):
New feature: incremental VLAN interface management for OpenBSD and
FreeBSD. When user adds or removes VLAN subinterface in fwbuilder
GUI, geenrated script executes appropriate ifconfig commands to
add or remove corresponding vlan pseudo-interface on the firewall
machine.
2010-02-14 03:23:25 +00:00
Vadim Kurland
01a79aeed5 * OSConfigurator_bsd.cpp (OSConfigurator_bsd::updateAddressesOfInterfaceCall):
New feature: incremental IP address management for OpenBSD and
FreeBSD. Generated script adds and removes ipv4 and ipv6 addresses
of interfaces as needed. When user adds an address in the
fwbuilder object, the script adds it. Second run of the same script
does nothing. If user removes an address in fwbuilder, generated
script removes it from the interfaces to bring actual configuration
of the machine in sync with fwbuilder objects.
2010-02-13 05:15:38 +00:00
Illya Yalovoy
795831d77f ChangeLog 2010-02-12 15:09:54 +00:00
Vadim Kurland
bf96712bbb * UsageResolver.cpp (list): fixes #1222 modification of host or fw
settings of a member firewall does not trigger cluster recompile
2010-02-11 00:36:40 +00:00
Vadim Kurland
927d21cb8f * InterfaceDialog.cpp (InterfaceDialog::validate): fixes #1221
warning dialogs for the incorrect interface name would not go
away.  If user entered incorrect name of the
subinterace (e.g. name that is not a valid VLAN subinterface name)
the GUI would pop up warning dialog infinitely.
2010-02-10 23:46:54 +00:00
Vadim Kurland
bd08467dde * ../src/gui/ProjectPanel_events.cpp (ProjectPanel::event): this
change attempts to fix a bug that causes main menu item Edit /
Paste (keyboard shortcut Ctrl-V) to stop working. The bug is hard
to reproduce and we were not able to find reliable scenario to
trigger it.
2010-02-10 22:46:03 +00:00
Vadim Kurland
c73c00658f * PolicyCompiler_ipt.cpp (specialCaseWithFWInDstAndOutbound::processNext):
fixes #1220 "bridging fw rule using all multicast object in
destination does not produce any iptables rules".
2010-02-10 22:10:44 +00:00
Vadim Kurland
bfb90b9324 * src/gui/ClusterGroupDialog.cpp (ClusterGroupDialog::applyChanges):
fixes #1215 "Edit protocol parameters" button gets disabled for no
reason. This button would get disabled after certain manipulations
in the cluster group object dialog even when no changes were made.
2010-02-07 21:12:36 +00:00
Vadim Kurland
d241ce0b9c * FWCmdChange.cpp (FWCmdChangeOptionsObject::notify): fixes #1212
Cluster object was not marked for recompile when user edited
conntrack group parameters
2010-02-07 17:48:12 +00:00
Vadim Kurland
a0314a7d97 * src/pflib/PolicyCompiler_pf_writers.cpp (PrintRule::processNext):
fixes #1210 "syntax error in PF rule - "modulate state" is
required".  Per bug reported in the mailing list (and according to
the pf.conf manual), pf.conf requires "keep state", "modulate
state" or "synproxy"if any of the stateful tracking options are
used in the rule. These include "max", "no-sync", "pflow",
"sloppy", "source-track" and others.
2010-02-07 05:24:21 +00:00
Vadim Kurland
8fae13fbd9 * src/pflib/PolicyCompiler_pf_writers.cpp (PrintRule::processNext):
fixes #1209 "incorrect syntax in PF rules when only "Activate
source tracking" option is on". Compiler sometimes generated empty
"( )" in the end of the pf.conf line when there were no state
tracking options
2010-02-07 05:05:33 +00:00
Vadim Kurland
e50fcd4beb * PolicyCompiler_ipt.cpp (PolicyCompiler_ipt::insertConntrackRule):
fixes #1175 "There is no option for unicast on conntrac
sync-group (like heartbeat)". User can now choose between multicast
and unicast for conntrackd communication.
2010-02-07 04:31:52 +00:00
Vadim Kurland
2506e35544 * FWWindow.cpp (FWWindow::showWelcome): fixes #1213 Welcome screen.
When user starts the program for the very first time, it shows
a "Welcome" screen that lists summary of features of fwbuilder and
provides a link to the Getting Started Guide on the web site. Link
to the local copy of Release Notes is also provided.
2010-02-07 02:47:03 +00:00
Vadim Kurland
62d10558d9 * linux24.xml, openwrt.xml: fixed #1172 It is ok for a cluster
interface with failover protocol heartbeat to have no ip address.
There are legitimate configurations where admin might want to run
heartbeat over an inetrface which itself has no virtual ip
address, for example to confine heartbeat packets to a dedicated
link.
2010-02-07 01:06:36 +00:00
Vadim Kurland
fc3621afc5 * FWObjectPropertiesFactory.cpp (FWObjectPropertiesFactory::getObjectPropertiesDetailed):
fixes #1201 "add parent to the object properties tooltip".
Include parent name in the tooltip that is shown for interface
objects.  This helps identify interfaces in rules, especially
subinterfaces and interfaces with common names in complex
configurations with many firewall objects.
2010-02-03 01:36:48 +00:00
Vadim Kurland
444fb52e8d * NATCompiler_ipt.cpp (ReplaceFirewallObjectsTSrc::processNext):
fixes #1200 "SNAT with cluster object in TSrc uses all
interfaces".  When a network or host address used in OSrc of a NAT
rule matches one of the interfaces of the firewall or a cluster,
there is not need to use this interface for the "-o" clause in
SNAT rule.
2010-02-03 01:20:24 +00:00
Vadim Kurland
312faac34b fixes #1207 2010-02-03 00:32:51 +00:00
Vadim Kurland
6df83ec139 * FWWindow.cpp (FWWindow::fileExit): fixes #1197 "clicking Cancel
in RCS log dialog cancels log but the program still exits".
2010-02-02 00:24:34 +00:00
Vadim Kurland
20d4f1323e * CompilerDriver.cpp (CompilerDriver::populateClusterElements):
see #1198. The check of subnets defined by the member and cluster
interfaces has been removed. The check originally implemented by
Secuwall developers looked only at the first address of the
interface and ignored others. It also did not allow for the
cluster interface netmask /32, which is the case with vrrpd. All
in all, the value here does not seem to be worth the effort of
implementing checks for all combinations.
2010-02-02 00:04:22 +00:00
Vadim Kurland
6efeea28ac * ../src/res/configlets/linux24/update_addresses: fixes #1196
"shell function update_addresses_of_interface() does not ignore
virtual addresses of cluster inetrfaces". When generated iptables
script updates ip addresses of interfaces, it should ignore
addresses managed by vrrpd, heartbeat or other failover daemons.
The script did not ignore them and instead removed them from
interfaces.
2010-02-01 23:44:42 +00:00
Vadim Kurland
591c5da521 * objects_init.xml: fixes #1194 "Add standard address objects for
various multicast groups". Added address objects for standard
multicast groups OSPF, RIP, EIGRP, DHCP server / relay agent, PIM,
RSVP-ENCAPSULATION, VRRP, IGMP, OSPFIGP-TE, HSRP, mDNS, Link-local
Multicast Name Resolution, Teredo.
2010-02-01 21:36:38 +00:00