1
0
mirror of https://github.com/fwbuilder/fwbuilder synced 2026-03-22 03:07:20 +01:00

770 Commits

Author SHA1 Message Date
Vadim Kurland
4ecb807f23 * IPTImporter.cpp (IPTImporter::finalize): see #1513 iptables
importer should check default policy in standard chains.
2010-06-11 20:27:35 +00:00
Vadim Kurland
9cfe3b9866 last patch to fix Makefile warnings; fixes #1510 2010-06-08 22:34:52 +00:00
Vadim Kurland
c9ed497303 * applied patch from slif@bellsouth.net to fix compiler
warnings. Patch applied partially since not all fixes were
appropriate.
2010-06-08 20:35:48 +00:00
Vadim Kurland
f2e206c38b * IPTImporter.cpp (IPTImporter::pushPolicyRule): policy importer
for iptables can now parse numerical log levels.
2010-06-08 20:17:28 +00:00
Vadim Kurland
c153b341c3 * IPTImporter.cpp (IPTImporter::pushPolicyRule): fixed #1512 SF
bug 3012953: iptables importer sometimes does not recognize rule
with " ESTABLISHED,RELATED ". Parser properly processed iptables
rules with state "RELATED,ESTABLISHED" but not when states were
in the opposite order.
2010-06-08 19:57:49 +00:00
Vadim Kurland
71f893b213 * Importer.cpp (Importer::getUDPService): fixed sourceforge bug
3012953 name of UDP and TCP objects created during import should
follow the same pattern and not include "0-0" for the source ports
if they are equal to zero.
2010-06-08 19:49:47 +00:00
Vadim Kurland
89128241ed * IPTImporter.cpp (IPTImporter::IPTImporter): fixed #1511, SF bug 3012953:
iptables import parse error icmp_type any
2010-06-08 19:26:50 +00:00
Vadim Kurland
9f00e4e619 * CompilerDriver_pix_run.cpp (CompilerDriver_pix::pixNetworkZoneChecks):
fixed #1491 fwb_pix crashes trying to compile simple rule. Compiler
should check validity of the object used as network zone of an interface.
2010-06-08 00:56:07 +00:00
Vadim Kurland
6352889c72 * FWBSettings.cpp (FWBSettings::init): fixed #1501 call qsrand(seed)
to seed random generator before generating new UUID
2010-06-08 00:02:19 +00:00
Vadim Kurland
e6d0a5826e * TransferDevice.h (fwtransfer): fixed #1490 compile problem with
Qt 4.7
2010-06-07 23:41:55 +00:00
Vadim Kurland
474cb2ad79 * FWWindow.cpp (FWWindow::prepareRulesMenu): fixed #1489 removed
unnecessary debugging messages.
2010-06-07 23:37:10 +00:00
Vadim Kurland
25b3df4184 * interfaceProperties.cpp (interfaceProperties::manageIpAddresses):
fixed #1506 SF bug #3011516: generated iptables script tries to
update ip addresses of unnumbered interface.
2010-06-07 22:40:54 +00:00
Vadim Kurland
bece6c98c1 started v4.0.2 2010-06-07 17:54:34 +00:00
Vadim Kurland
cc35f57f19 * FWBSettings.cpp (FWBSettings::FWBSettings): using separate
settings object and file in the .ini format to store instance uuid
to ensure uuid persistence on windows across upgrades done with
complete deinstall. Fixes #1497
2010-06-06 19:34:37 +00:00
Vadim Kurland
a9aa4dd623 * UserWorkflow.cpp (UserWorkflow::flagsToQueryString): added user
workflow progress flags for an attempted install and first
successful install. Both flags are boolean true/false indicating
that the even occurred. We do not track and do not report any
information about the firewall, platform, rules etc. These flags
will be used to determine how many users abandon the program
before even trying to run install for real because it is too
complicated or the UI is not good enough. Fixes #1495

* UserWorkflow.cpp (UserWorkflow::flagsToQueryString): added user
workflow flag indicating that ssh/scp have been configured in the
Prefereces dialog. The flag is boolean and registers only the fact
that something was entered in ssh and scp fields. Actual path and
programs used are not registered and reported. Fixes #1496
2010-06-06 18:50:36 +00:00
Vadim Kurland
d57bd1cf0b * Preprocessor.cpp (Preprocessor::findMultiAddressObjectsUsedInRules):
change in libfwbuilder: fixed #1485 "dns name object is recognized
as an empty group when it appears in shared rule set"
2010-06-02 16:51:58 +00:00
Illya Yalovoy
8e7329fdd2 fixes #1484 "paste below" function pastes rules out of order 2010-06-02 06:44:37 +00:00
Vadim Kurland
e4e73b86e8 * Help.cpp (Help::downloadComplete): fixed #1482 Class Help should
open window only after successful download
2010-06-01 17:02:51 +00:00
Vadim Kurland
edfdf00c73 * ObjConflictResolutionDialog.cpp (ObjConflictResolutionDialog::run):
refs #1483 If program detects change in CustomService object and
the change just adds code string for a platform that was not
in the object in the users data file, the change is accepted without
showing the dialog.

* ../src/res/objects_init.xml.in: fixed #1483 "missing code in the
custom service object ESTABLISHED for ProCurve"
2010-06-01 16:37:35 +00:00
Vadim Kurland
5ae0d3e798 * FWWindow.cpp (FWWindow::checkForUpgrade): added mechanism for
one-time announcements that can be pulled from the web site
when version check server says there is one. Announcement is
shown only once. To do this, I store time stamp when it was shown
in settings using hash of the announcement url.

* Help.cpp (Help::setSource): made class Help capable of
downloading contents via HTTP.
2010-06-01 00:29:15 +00:00
Vadim Kurland
cbdc5e9a97 * FirewallDialog.cpp (FirewallDialog::fillVersion): fixed #1481
when user changes platform in the firewall object, its version
should change too.
2010-05-31 16:25:35 +00:00
Vadim Kurland
2233efa6e8 added session duration and http proxy to the flags included in the closing report 2010-05-29 00:02:15 +00:00
Vadim Kurland
b384feabb6 see #1447 Reverting change done for ticket #1447 in r2892 and
r2896 because of the user complaints. It appears to be more
convenient if Policy, NAT and Routing objects open in the rule set
view on double click but not in the editor. Second double clik
opens these objects in the editor.
2010-05-28 23:37:03 +00:00
Vadim Kurland
f178cb18b2 * configure.in (CPPUNIT_LIBS): fixed #1478 always use included
antlr run-time library.
2010-05-25 23:07:52 +00:00
Vadim Kurland
91cdf9171e 2010-05-24 vadim <vadim@vk.crocodile.org>
* UserWorkflow.cpp (UserWorkflow::report): see #1466 Implemented
instrumentation that should help us improve user experience. Will
track few things that new users do (or dont) and report as a
combination of bit flags at the end of the GUI session. Reporting
things such as if user looked at "Getting Started" tutorial, if
they created their first firewall object, modified any rules,
tried to compile or install. Information passed in the report is
strictly a set of boolean flags, is not identifiable and does not
reveal what firewall platform they are using or anything about
their objects and rules.
2010-05-25 05:20:25 +00:00
Vadim Kurland
6c61862e0e patch by Vadim Jukov <persgray@gmail.com> OpenBSD port maintainer 2010-05-24 00:30:39 +00:00
Vadim Kurland
3646375e76 * FWCmdAddObject.cpp (FWCmdAddObject::redo): fixed #1468 Open new
object in the editor after it has been created.
2010-05-23 17:10:07 +00:00
Illya Yalovoy
fd61b329d9 fixes #1469 some actions should always display argument, even when text labels for actions and directions is off 2010-05-22 17:49:19 +00:00
Illya Yalovoy
beb4cedcc4 fixes #1463 Always show branch rule set name with action "Branch" 2010-05-22 16:46:14 +00:00
Vadim Kurland
32698c6643 fixes #1467: "rule options dialog shows iptables parameters for
procurve_acl"
2010-05-22 01:32:13 +00:00
Vadim Kurland
39d7b6af9a fixes #1457 "tooltips for rule options seem to be broken". Tooltip
always includes the line telling of the rule is "stateful" or
"stateless", the function almost never returns empty string now.
2010-05-22 01:16:06 +00:00
Vadim Kurland
3baef787b9 * ProjectPanel.cpp (ProjectPanel::addRule): fixed #1461 Need
obvious button to add new rule to the empty rule set
2010-05-20 22:11:27 +00:00
Vadim Kurland
bfca1889ed * instDialog.cpp (instDialog::show): fixed #1462 "if you do a bulk
install, and then want to do a single install, bulk mode is
selected"
2010-05-20 19:05:30 +00:00
Vadim Kurland
1ab2cbba04 * ActionsDialog.cpp (ActionsDialog::setRule): fixed #1464
SourceForge bug 3004274: "Branch rule set object displays
improperly".  Branch rule set attribute was not loaded properly
into Branch action dialog for rules of PF firewalls.
2010-05-20 17:57:53 +00:00
Vadim Kurland
cedb9620bd * PolicyCompiler_iosacl_writers.cpp (PrintRule::_printRule):
restored function of the "comment the code" in the "Script
options" of the firewall settings dialog for Cisco IOS ACL and
ProCurve ACL. When this checkbox is off, comments are not
added to generated script.
2010-05-17 20:36:48 +00:00
Vadim Kurland
0c23d17304 * RuleSetViewDelegate.cpp (RuleSetViewDelegate::paintOptions):
fixed #1460 "when "show icons in rules" is turned off, there is no
way to tell when logging is turned on and non-default options are
present in a rule".

* fixed #1339 "Logging" icon appears looking the same as "Rule
options" icon on Mac
2010-05-17 19:32:14 +00:00
Vadim Kurland
648c843d29 * linux24Interfaces.cpp (linux24Interfaces::basicValidateInterfaceName):
fixed #1458 Should permit interface name "br-lan" for bridge interface
on Linux. Bridge interfaces on Linux can have any name, including those
with "-". OpenWRT creates bridge interface with the name "br-lan" by
default.
2010-05-16 03:09:14 +00:00
Vadim Kurland
096fffb11b * update_addresses: fixed #1455 Function update_addresses() (host
OS linux24 and derivatives) uses both ip and ifconfig. Should stick
with /sbin/ip so the script works on systems where ifconfig is
not installed.
2010-05-14 18:19:15 +00:00
Vadim Kurland
7b4c53eaeb * FWObjectDropArea.cpp (FWObjectDropArea::editObject): fixed #1452
double click on a rule set in the branch action dialog should open
it in rule set view
2010-05-14 03:15:57 +00:00
Vadim Kurland
fb88dc29e5 * iptables.g (multiport_tcp_udp_port_spec): fixes #1453 "iptables
importer should parse multiport module parameter --ports". Module
multuport with parameter "--ports" matches either source or
destination port numbers. Importer creates two tcp (or udp)
service objects to implement this match.
2010-05-14 01:54:05 +00:00
Vadim Kurland
fe5a13d1b5 * iptables.g (MATCH_RECENT_SET): see #1451 "policy importer should
support some popular iptables modules". Added support for module
"recent" and rules that match standard ip/icmp/udp/tcp protocols
and at the same time module "mark", "length", "limit" or "recent".
Rules like these are translated into a combination of a branching
rule and additional rule in a branch rule set that implements
module match.
2010-05-14 00:54:03 +00:00
Vadim Kurland
2b15e55d77 * IPTImporter.cpp (IPTImporter::addSrv): See #1450, SourceForge
ticket 3000809: iptables parser can now import "mark" module
matches with hexadecimal parameters and "length" module
matches. Also added check in the importer for broken iptables-save
files where rules for any table are not terminated with "COMMIT".
2010-05-13 19:39:45 +00:00
Vadim Kurland
1378ab08b3 added installer commands for ProCurve, using the same code for Cisco and ProCurve 2010-05-12 21:45:32 +00:00
Vadim Kurland
4a246aa75c fixed #1449 options for ACL remarks and comments for ProCurve 2010-05-12 21:28:50 +00:00
Vadim Kurland
b4eeb1563d newline after exit in commands that attach acl to regular interface; generating different commands depending on whether management interface is vlan or not 2010-05-12 15:08:27 +00:00
Vadim Kurland
19abf81f05 * ObjectManipulatorTest.cpp (ObjectManipulatorTest::editSelectedObject):
see #1447 fixed unit test for this change
2010-05-12 02:46:22 +00:00
Vadim Kurland
45c764834e fixes #1448 "need to commit nvram changes on DD-WRT". 2010-05-11 17:23:58 +00:00
Vadim Kurland
39da135a34 fixes #1447 context menu item Edit associated with rule set should open in the editor 2010-05-11 17:21:31 +00:00
Vadim Kurland
8f9b516e9b using different xml element to control when "advanced interface settings" button is enabled; generating different commands to bind acls to vlan or regular inetrfaces on ProCurve 2010-05-11 17:01:08 +00:00
Vadim Kurland
b002797fce see #1442 experimental support for HP ProCurve, using configlet to generate "safety net" config for IOS and ProCurve 2010-05-11 02:59:53 +00:00