mirror of
https://github.com/fwbuilder/fwbuilder
synced 2026-09-13 08:29:32 +02:00
partial fix for bugs #1789059 and 1945149
This commit is contained in:
@@ -1,3 +1,18 @@
|
|||||||
|
2008-05-08 vadim <vadim@vk.crocodile.org>
|
||||||
|
|
||||||
|
* PolicyCompiler.cpp (PolicyCompiler::checkForShadowing): (from
|
||||||
|
2.1): partial fix for bugs #1789059 "shadow issue when using
|
||||||
|
action chain" and #1945149: "Shadowing test for rules with action
|
||||||
|
"chain". The mechanism for rule shadowing detection we have at
|
||||||
|
this time can only detect shadowing of one rule by another. In
|
||||||
|
case of branching it is a combination of the branching rule and
|
||||||
|
rules inside the branch that may shadow other rules. I plan to
|
||||||
|
redesign this part of the code in the future, but it won't happen
|
||||||
|
in upcoming v3.
|
||||||
|
|
||||||
|
Meanwhile, I am fixing it in 2.1 by making compiler ignore rules
|
||||||
|
with action Branch.
|
||||||
|
|
||||||
2008-05-05 vadim <vadim@vk.crocodile.org>
|
2008-05-05 vadim <vadim@vk.crocodile.org>
|
||||||
|
|
||||||
* PolicyCompiler_pf_writers.cpp (PrintRule::processNext),
|
* PolicyCompiler_pf_writers.cpp (PrintRule::processNext),
|
||||||
|
|||||||
@@ -3631,6 +3631,8 @@ void PolicyCompiler_ipt::compile()
|
|||||||
{
|
{
|
||||||
add( new Begin("Detecting rule shadowing"));
|
add( new Begin("Detecting rule shadowing"));
|
||||||
|
|
||||||
|
add( new Branching("fold in branches"));
|
||||||
|
|
||||||
addRuleFilter();
|
addRuleFilter();
|
||||||
|
|
||||||
add( new printTotalNumberOfRules());
|
add( new printTotalNumberOfRules());
|
||||||
|
|||||||
Reference in New Issue
Block a user