onkelbeh/esphome_kamstrup
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Code review fixes

Browse Source
This commit is contained in:
Chris Feenstra 2023-11-07 12:07:24 +00:00
parent b1fb9eb9b1
commit a75af2bb1d
2 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
esphome/components/kamstrup_kmp/kamstrup_kmp.h
View File

@ -75,20 +75,20 @@ static const char *const UNITS[] = {
class KamstrupKMPComponent : public PollingComponent, public uart::UARTDevice { class KamstrupKMPComponent : public PollingComponent, public uart::UARTDevice {
public: public:
void set_heat_energy_sensor(sensor::Sensor *sensor) { heat_energy_sensor_ = sensor; } void set_heat_energy_sensor(sensor::Sensor *sensor) { this->heat_energy_sensor_ = sensor; }
void set_power_sensor(sensor::Sensor *sensor) { power_sensor_ = sensor; } void set_power_sensor(sensor::Sensor *sensor) { this->power_sensor_ = sensor; }
void set_temp1_sensor(sensor::Sensor *sensor) { temp1_sensor_ = sensor; } void set_temp1_sensor(sensor::Sensor *sensor) { this->temp1_sensor_ = sensor; }
void set_temp2_sensor(sensor::Sensor *sensor) { temp2_sensor_ = sensor; } void set_temp2_sensor(sensor::Sensor *sensor) { this->temp2_sensor_ = sensor; }
void set_temp_diff_sensor(sensor::Sensor *sensor) { temp_diff_sensor_ = sensor; } void set_temp_diff_sensor(sensor::Sensor *sensor) { this->temp_diff_sensor_ = sensor; }
void set_flow_sensor(sensor::Sensor *sensor) { flow_sensor_ = sensor; } void set_flow_sensor(sensor::Sensor *sensor) { this->flow_sensor_ = sensor; }
void set_volume_sensor(sensor::Sensor *sensor) { volume_sensor_ = sensor; } void set_volume_sensor(sensor::Sensor *sensor) { this->volume_sensor_ = sensor; }
void setup() override; void setup() override;
void dump_config() override; void dump_config() override;
float get_setup_priority() const override; float get_setup_priority() const override;
void update() override; void update() override;
void set_custom_sensor(int i, sensor::Sensor *sensor, uint16_t command) { void add_custom_sensor(sensor::Sensor *sensor, uint16_t command) {
this->custom_sensors_.insert(this->custom_sensors_.begin() + i, sensor); this->custom_sensors_.push_back(sensor);
this->custom_commands_.insert(this->custom_commands_.begin() + i, command); this->custom_commands_.push_back(command);
} }
protected: protected:

4
esphome/components/kamstrup_kmp/sensor.py
View File

@ -127,6 +127,6 @@ async def to_code(config):
# Custom sensors # Custom sensors
if CONF_CUSTOM in config: if CONF_CUSTOM in config:
for i, conf in enumerate(config[CONF_CUSTOM]): for conf in config[CONF_CUSTOM]:
sens = await sensor.new_sensor(conf) sens = await sensor.new_sensor(conf)
cg.add(getattr(var, "set_custom_sensor")(i, sens, conf[CONF_COMMAND])) cg.add(var.add_custom_sensor(sens, conf[CONF_COMMAND]))