Contributions #1527

New Issue

ustinov · 2023-05-21T17:30:31+02:00

ustinov commented

2023-05-21 17:30:31 +02:00

Hi, i think i can help with some of dependency-bumping from time to time. But it would be great, if a short instruction for making helpful conributions existed (do-s, dont-s, general workflow). Or i can just start to make pull-requests.

onkelbeh commented

2023-05-28 08:18:40 +02:00

Hi,

thanks for your offer. PR are always welcome.
I'll create the branch for 2023.5 soon.

Currently there's a lot of cleanup to do, because Michał Górny broke a lot by removing the mirror://pypi from Gentoo, affecting 2723 Ebuilds in this repo. And a lot of Issues (missing packages for 2023.5.4) are waiting in the queue.

Next, I'm currently very busy otherwise, we are replacing our oil-fired heating with a heatpump, so there's only a little time left.

Any help is very appreciated.

Hi, thanks for your offer. PR are always welcome. I'll create the branch for 2023.5 soon. Currently there's a lot of cleanup to do, because Michał Górny broke a lot by removing the mirror://pypi from Gentoo, affecting 2723 Ebuilds in this repo. And a lot of Issues (missing packages for 2023.5.4) are waiting in the queue. Next, I'm currently very busy otherwise, we are replacing our oil-fired heating with a heatpump, so there's only a little time left. Any help is very appreciated.

onkelbeh commented

2023-05-28 09:10:58 +02:00

Heres a short overview of what I am doing when a new release approaches, I am sure there a some things that could be done better.

First, I have no hurry in adopting the early releases (.0 or .1), these often have breaking bugs and they are work, too.

I have a script checking the arriving deps for the new version, it creates tickets for missing packages, unfortunatly it does not (yet) check for already opened tickets, so there are dupes. I pick on from the queue, check for dupes, mark & close them.

As an example:
zigpy-0.55.0, i make a copy of the last release (0.54.1) to 0.55.0, open it, and check for:

have deps changed at upstream (https://github.com/zigpy/zigpy), in this case setup.py
does it already use pypi.eclass
does it use DISTUTILS_USE_PEP517

Then:

check for unused older releases and remove them (this time I removed two old major releases, so I can remove more old Ebuilds, hoping that I have to fix not so many mirror://pypi
rebuild Manifest
run pkgcheck scan, fix problems
compile with tests (if they have any)

and if compile succeeds:

commit it to a dev branch

There are some examples for WF in the Gentoo wiki:

If you have questions, please ask.

Heres a short overview of what I am doing when a new release approaches, I am sure there a some things that could be done better. First, I have no hurry in adopting the early releases (.0 or .1), these often have breaking bugs and they are work, too. I have a script checking the arriving deps for the new version, it creates tickets for missing packages, unfortunatly it does not (yet) check for already opened tickets, so there are dupes. I pick on from the queue, check for dupes, mark & close them. As an example: zigpy-0.55.0, i make a copy of the last release (0.54.1) to 0.55.0, open it, and check for: * have deps changed at upstream (https://github.com/zigpy/zigpy), in this case setup.py * does it already use pypi.eclass * does it use DISTUTILS_USE_PEP517 Then: * check for unused older releases and remove them (this time I removed two old major releases, so I can remove more old Ebuilds, hoping that I have to fix not so many `mirror://pypi` * rebuild Manifest * run pkgcheck scan, fix problems * compile with tests (if they have any) and if compile succeeds: * commit it to a dev branch There are some examples for WF in the Gentoo wiki: * https://wiki.gentoo.org/wiki/Standard_git_workflow * https://wiki.gentoo.org/wiki/Gentoo_git_workflow If you have questions, please ask.

ustinov commented

2023-05-28 09:25:53 +02:00

Thanks, it is quite clear - i run a small overlay myself (which was also a bit broken by said mirror://pypi deprecation). The question was mostly about quality standarts (and those are covered well in previous message)

ustinov commented

2023-05-28 10:03:39 +02:00

Is ssh-cloning from git.edevau.net somehow restricted?

onkelbeh commented

2023-05-30 15:14:43 +02:00

Currently, yes, it's an internal Webserver, only https is forwarded.

I can add a forwarding, do you have a fixed IP?

Currently, yes, it's an internal Webserver, only https is forwarded. I can add a forwarding, do you have a fixed IP?

onkelbeh commented

2023-05-30 15:23:50 +02:00

AH. Did not see tha last question. Sorry. Screen's too small ;-)

The thing I am currently thinking about is what to do with modules which have tests on their Gihub repo, many of them do not include the tests in the SDIST.

For the 'big' Ebuild I currently pull both (the SDIST an GH) and merge the tests.

Currently I am busy enough getting all modules filed in Ebuilds, so it's OK (for the most modules) if they emerge without error.

I have shellcheck running against the Ebuilds, and I run the most recent pkgcheck.

Just gave you read permission to https://git.edevau.net/onkelbeh/ha-tools, this is a set of scripts I use, I am afraid that most scripts won't work without the database (also behind a firewall). But this could be solved if you have a fixed IP :-) ... otherwise we can use a tunnel.

AH. Did not see tha last question. Sorry. Screen's too small ;-) The thing I am currently thinking about is what to do with modules which have tests on their Gihub repo, many of them do not include the tests in the SDIST. For the 'big' Ebuild I currently pull both (the SDIST an GH) and merge the tests. Currently I am busy enough getting all modules filed in Ebuilds, so it's OK (for the most modules) if they emerge without error. I have shellcheck running against the Ebuilds, and I run the most recent pkgcheck. Just gave you read permission to https://git.edevau.net/onkelbeh/ha-tools, this is a set of scripts I use, I am afraid that most scripts won't work without the database (also behind a firewall). But this could be solved if you have a fixed IP :-) ... otherwise we can use a tunnel.

fariouche commented

2023-07-11 21:29:18 +02:00

Hello!
Do you have some visibility on when you will have something back on track?

Hello! Do you have some visibility on when you will have something back on track?

onkelbeh commented

2023-07-11 23:09:47 +02:00

Nope, sorry, not yet, thanks to M. Gorny who removed the mirror part from python Eclass with any prior notice, so all Ebuilds are to be reworked.

They run into a:
UnknownMirror: version 2022.10.4: unknown mirror 'pypi' from URI 'mirror://pypi/v/velbus-aio/velbus-aio-2022.10.4.tar.gz'
MissingUri: version 2022.12.0: unfetchable file: 'velbus-aio-2022.12.0.tar.gz‘

2023.4.6-r1 should be compilable, but you have to use a Gentoo Repo from March.

I’m just 2/3 through, currently (a-z) at the letter „m“

… and unfortunately currently quite busy otherwise, it’s festival season, so many weekends working, and I have to swap the heating system in my house before autumn…

I decided to skip some majors and jump to 2023.7 for cleanup/development.

Think fixing this all will take some more days, perhaps weeks, feel free to help :-)

Work is done in https://git.edevau.net/onkelbeh/HomeAssistantRepository/src/branch/2023.5.4

Nope, sorry, not yet, thanks to M. Gorny who removed the mirror part from python Eclass with any prior notice, so all Ebuilds are to be reworked. They run into a: UnknownMirror: version 2022.10.4: unknown mirror 'pypi' from URI 'mirror://pypi/v/velbus-aio/velbus-aio-2022.10.4.tar.gz' MissingUri: version 2022.12.0: unfetchable file: 'velbus-aio-2022.12.0.tar.gz‘ 2023.4.6-r1 should be compilable, but you have to use a Gentoo Repo from March. I’m just 2/3 through, currently (a-z) at the letter „m“ … and unfortunately currently quite busy otherwise, it’s festival season, so many weekends working, and I have to swap the heating system in my house before autumn… I decided to skip some majors and jump to 2023.7 for cleanup/development. Think fixing this all will take some more days, perhaps weeks, feel free to help :-) Work is done in https://git.edevau.net/onkelbeh/HomeAssistantRepository/src/branch/2023.5.4

fariouche commented

2023-07-12 20:31:30 +02:00

Thanks!
Yeah, I decided to upgrade to 2023.7 (I'm still running 2023.3) when I discovered the horror. I didn't see any message about pipy

I will switch to the branch and try to help.
From what I've seen, it is mainly modifying all the ebuilds that uses mirror://pipy and use instead the pipy eclass in the inherit line, right?

I'm asking because I failed to get the ebuild to download the package for most ebuilds (the eclass generate a wrong url, replacing dash by underscores)
One package failed to compile (wrong S variable value)
And, ha-av does not compile against ffmpeg 6 (easy fix, they release a new ha-av 10.1.0 if I remember properly that works)

By the way, I'm having regular down times from your server, several minutes every 3min or so...

Thanks! Yeah, I decided to upgrade to 2023.7 (I'm still running 2023.3) when I discovered the horror. I didn't see any message about pipy I will switch to the branch and try to help. From what I've seen, it is mainly modifying all the ebuilds that uses mirror://pipy and use instead the pipy eclass in the inherit line, right? I'm asking because I failed to get the ebuild to download the package for most ebuilds (the eclass generate a wrong url, replacing dash by underscores) One package failed to compile (wrong S variable value) And, ha-av does not compile against ffmpeg 6 (easy fix, they release a new ha-av 10.1.0 if I remember properly that works) By the way, I'm having regular down times from your server, several minutes every 3min or so...

onkelbeh commented

2023-07-16 21:34:33 +02:00

Yep, here are my frequently used strings from the editor:

DISTUTILS_USE_PEP517=setuptools
PYPI_NO_NORMALIZE=1
inherit distutils-r1 pypi

PYPI_PN=${PN/-/.}

DISTUTILS_USE_PEP517=poetry
DISTUTILS_USE_PEP517=setuptools
inherit distutils-r1 pypi

SRC_URI="$(pypi_sdist_url --no-normalize "${MY_PN}")"
SRC_URI="$(pypi_sdist_url "${PN}" "${PV}" ".zip")"


drop olds, change SRC_URI
DISTUTILS_USE_PEP517 value

# pkgcheck  scan -k-BadDescription,-ExcessiveLineLength --color=true
# pkgcheck  scan -k-BadDescription,-ExcessiveLineLength --color=true | grep MissingUri | cut -d ":" -f4- | sort

Yep, here are my frequently used strings from the editor: ``` DISTUTILS_USE_PEP517=setuptools PYPI_NO_NORMALIZE=1 inherit distutils-r1 pypi PYPI_PN=${PN/-/.} DISTUTILS_USE_PEP517=poetry DISTUTILS_USE_PEP517=setuptools inherit distutils-r1 pypi SRC_URI="$(pypi_sdist_url --no-normalize "${MY_PN}")" SRC_URI="$(pypi_sdist_url "${PN}" "${PV}" ".zip")" drop olds, change SRC_URI DISTUTILS_USE_PEP517 value ``` ```bash # pkgcheck scan -k-BadDescription,-ExcessiveLineLength --color=true # pkgcheck scan -k-BadDescription,-ExcessiveLineLength --color=true | grep MissingUri | cut -d ":" -f4- | sort ```