diff --git a/src/cisco_lib/PolicyCompiler_pix.cpp b/src/cisco_lib/PolicyCompiler_pix.cpp index 6a8f4aa3b..fb1df1067 100644 --- a/src/cisco_lib/PolicyCompiler_pix.cpp +++ b/src/cisco_lib/PolicyCompiler_pix.cpp @@ -782,7 +782,7 @@ string PolicyCompiler_pix::printPreambleCommands() try { - InetAddr(addr); + (void) InetAddr(addr); } catch(FWException &ex) { abort("Invalid address for management subnet: '"+addr+"'"); diff --git a/src/fwbedit/fwbedit.cpp b/src/fwbedit/fwbedit.cpp index 34c4f9270..b51047e48 100644 --- a/src/fwbedit/fwbedit.cpp +++ b/src/fwbedit/fwbedit.cpp @@ -888,7 +888,7 @@ int main(int argc, char * const *argv) } catch (std::string s) { cerr << s; exit(1); - } catch (std::exception ex) { + } catch (std::exception &ex) { cerr << ex.what(); exit(1); } catch (...) { diff --git a/src/iosacl/iosacl.cpp b/src/iosacl/iosacl.cpp index ee8e72248..46eb9ec88 100644 --- a/src/iosacl/iosacl.cpp +++ b/src/iosacl/iosacl.cpp @@ -179,7 +179,7 @@ int main(int argc, char **argv) { cerr << s << endl; return 1; - } catch (std::exception ex) + } catch (std::exception &ex) { cerr << "exception: " << ex.what() << endl; return 1; diff --git a/src/iptlib/AutomaticRules_ipt.cpp b/src/iptlib/AutomaticRules_ipt.cpp index 809fae54e..779aa5705 100644 --- a/src/iptlib/AutomaticRules_ipt.cpp +++ b/src/iptlib/AutomaticRules_ipt.cpp @@ -104,7 +104,7 @@ void AutomaticRules_ipt::addConntrackRule() try { - InetAddr(addr); + (void) InetAddr(addr); } catch (FWException &ex) { try diff --git a/src/junosacl/junosacl.cpp b/src/junosacl/junosacl.cpp index b3ed7fa66..9460a189a 100644 --- a/src/junosacl/junosacl.cpp +++ b/src/junosacl/junosacl.cpp @@ -179,7 +179,7 @@ int main(int argc, char **argv) { cerr << s << endl; return 1; - } catch (std::exception ex) + } catch (std::exception &ex) { cerr << "exception: " << ex.what() << endl; return 1; diff --git a/src/libfwbuilder/src/fwcompiler/PolicyCompiler.cpp b/src/libfwbuilder/src/fwcompiler/PolicyCompiler.cpp index ae6ffc35c..b57ea4eb2 100644 --- a/src/libfwbuilder/src/fwcompiler/PolicyCompiler.cpp +++ b/src/libfwbuilder/src/fwcompiler/PolicyCompiler.cpp @@ -567,7 +567,7 @@ PolicyCompiler::find_more_specific_rule( return j; } - } catch (FWException ex) { + } catch (FWException &ex) { cerr << " *** Exception: " << ex.toString() << endl; } } diff --git a/src/libgui/ObjectTreeView.cpp b/src/libgui/ObjectTreeView.cpp index 1c845da55..648b398f4 100644 --- a/src/libgui/ObjectTreeView.cpp +++ b/src/libgui/ObjectTreeView.cpp @@ -957,13 +957,13 @@ static bool filterMatchesIpAddress(const QStringList &args, InetAddr ipv4addr(rx.cap(1).toStdString()); InetAddr ipv4mask(netmask); searchAddrAndMask = InetAddrMask(ipv4addr, ipv4mask); - } catch (const FWException) { // Could not create IPv4 object. Trying IPv6. + } catch (const FWException &) { // Could not create IPv4 object. Trying IPv6. try { int netmask = rx.cap(2).isEmpty() ? 128 : rx.cap(2).toInt(); InetAddr ipv6addr(AF_INET6, rx.cap(1).toStdString()); InetAddr ipv6mask(AF_INET6, netmask); searchAddrAndMask = InetAddrMask(ipv6addr, ipv6mask); - } catch (const FWException) { // Could not create IPv6 object. + } catch (const FWException &) { // Could not create IPv6 object. // User did not submit a valid IP address return false; } diff --git a/src/nxosacl/nxosacl.cpp b/src/nxosacl/nxosacl.cpp index be1cfd1dd..67bb1b301 100644 --- a/src/nxosacl/nxosacl.cpp +++ b/src/nxosacl/nxosacl.cpp @@ -179,7 +179,7 @@ int main(int argc, char **argv) { cerr << s << endl; return 1; - } catch (std::exception ex) + } catch (std::exception &ex) { cerr << "exception: " << ex.what() << endl; return 1; diff --git a/src/procurve_acl/procurve_acl.cpp b/src/procurve_acl/procurve_acl.cpp index 31a536e4d..2a5b933ad 100644 --- a/src/procurve_acl/procurve_acl.cpp +++ b/src/procurve_acl/procurve_acl.cpp @@ -179,7 +179,7 @@ int main(int argc, char **argv) { cerr << s << endl; return 1; - } catch (std::exception ex) + } catch (std::exception &ex) { cerr << "exception: " << ex.what() << endl; return 1;