diff --git a/build_num b/build_num index 81d899fe7..c02512b12 100644 --- a/build_num +++ b/build_num @@ -1 +1 @@ -#define BUILD_NUM 2764 +#define BUILD_NUM 2767 diff --git a/doc/ChangeLog b/doc/ChangeLog index 2f945a081..410d946ab 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -1,3 +1,12 @@ +2010-03-27 vadim + + * platforms.cpp (isDefaultPolicyRuleOptions): fixed #1365 "missing + some flags for the "non-default" rule options for PF" + + * FWObjectPropertiesFactory.cpp (FWObjectPropertiesFactory::getPolicyRuleOptions): + fixed #1364 "add synproxy and other missing pf rule options to the + rule options tooltip" + 2010-03-26 vadim * RuleSetModel.cpp (RuleSetModel::getDecoration): fixed #1363 diff --git a/src/gui/FWObjectPropertiesFactory.cpp b/src/gui/FWObjectPropertiesFactory.cpp index 091355b9f..2435fcf42 100644 --- a/src/gui/FWObjectPropertiesFactory.cpp +++ b/src/gui/FWObjectPropertiesFactory.cpp @@ -1117,8 +1117,18 @@ QString FWObjectPropertiesFactory::getPolicyRuleOptions(Rule *rule) res+=QObject::tr("Max src states: "); res+=QString(ropt->getStr("pf_max_src_states").c_str())+"
\n"; - } + + if (ropt->getBool("pf_synproxy")) + { + res+=QObject::tr("
  • synproxy
  • "); + } + + if (ropt->getBool("pf_modulate_state")) + { + res+=QObject::tr("
  • modulate_state
  • "); + } + res+=""; }else if (platform=="ipfw") diff --git a/src/gui/platforms.cpp b/src/gui/platforms.cpp index 445eeab91..8e241957a 100644 --- a/src/gui/platforms.cpp +++ b/src/gui/platforms.cpp @@ -252,7 +252,7 @@ bool isDefaultPolicyRuleOptions(FWOptions *opt) bool ge_4_5 = XMLTools::version_compare(version, "4.5")>=0; if (ge_4_5) { - res = (!opt->getBool("pf_no_sync") && opt->getBool("pf_pflow")); + res = (!opt->getBool("pf_no_sync") && !opt->getBool("pf_pflow")); } if (ge_4_0) @@ -265,7 +265,9 @@ bool isDefaultPolicyRuleOptions(FWOptions *opt) opt->getInt("pf_max_src_conn_rate_num")<=0 && opt->getInt("pf_max_src_conn_rate_seconds")<=0 && ! opt->getBool("pf_keep_state") && - ! opt->getBool("pf_sloppy_tracker") + ! opt->getBool("pf_sloppy_tracker") && + ! opt->getBool("pf_synproxy") && + ! opt->getBool("pf_modulate_state") ); }else { @@ -277,7 +279,9 @@ bool isDefaultPolicyRuleOptions(FWOptions *opt) opt->getInt("pf_max_src_conn_rate_num")<=0 && opt->getInt("pf_max_src_conn_rate_seconds")<=0 && ! opt->getBool("pf_keep_state") && - ! opt->getBool("pf_sloppy_tracker") + ! opt->getBool("pf_sloppy_tracker") && + ! opt->getBool("pf_synproxy") && + ! opt->getBool("pf_modulate_state") ); } } diff --git a/test/pf/objects-for-regression-tests.fwb b/test/pf/objects-for-regression-tests.fwb index 4f5038a23..1e037c12b 100644 --- a/test/pf/objects-for-regression-tests.fwb +++ b/test/pf/objects-for-regression-tests.fwb @@ -17611,7 +17611,7 @@ - + @@ -17764,7 +17764,44 @@ - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -17846,7 +17883,7 @@ - + @@ -18073,7 +18110,7 @@ - + @@ -18110,7 +18147,81 @@ - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +