diff --git a/doc/ChangeLog b/doc/ChangeLog index fef3e5d0e..3393f5c54 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -1,5 +1,10 @@ 2011-04-05 vadim + * PIXImporterNat.cpp (buildSNATRule): see #2310 "Imported global / + nat rule has wrong interface defined". Importer mixed up inbound + and outbound interfaces in NAT commands created from combination + of "global" and "nat" PIX/ASA commands. + * pix.g (nat_new_top_level_command): since import of ASA8.3 "new" nat commands is not implemented yet, importer should issue a warning when such command is encountered. See #2315 diff --git a/src/import/PIXImporterNat.cpp b/src/import/PIXImporterNat.cpp index 0010bbcb1..1278cb253 100644 --- a/src/import/PIXImporterNat.cpp +++ b/src/import/PIXImporterNat.cpp @@ -327,11 +327,11 @@ void PIXImporter::buildSNATRule() RuleElement *itf_i_re = rule->getItfInb(); assert(itf_i_re!=NULL); - itf_i_re->addRef(post_intf); + itf_i_re->addRef(pre_intf); RuleElement *itf_o_re = rule->getItfOutb(); assert(itf_o_re!=NULL); - itf_o_re->addRef(pre_intf); + itf_o_re->addRef(post_intf); // add it to the current ruleset current_ruleset->ruleset->add(rule); diff --git a/src/unit_tests/PIXImporterTest/test_data/pix7-nat.fwb b/src/unit_tests/PIXImporterTest/test_data/pix7-nat.fwb index 46d4fccba..7dfb1f42f 100644 --- a/src/unit_tests/PIXImporterTest/test_data/pix7-nat.fwb +++ b/src/unit_tests/PIXImporterTest/test_data/pix7-nat.fwb @@ -1,6 +1,6 @@ - + @@ -542,10 +542,10 @@ - + - + @@ -569,10 +569,10 @@ - + - + @@ -596,10 +596,10 @@ - + - + @@ -623,10 +623,10 @@ - + - + @@ -650,10 +650,10 @@ - + - + @@ -677,10 +677,10 @@ - + - + @@ -704,10 +704,10 @@ - + - + @@ -731,10 +731,10 @@ - + - + @@ -758,10 +758,10 @@ - + - +