From 0d1c8ce5332db33ef803f60dfb6b849d250b81f9 Mon Sep 17 00:00:00 2001 From: Vadim Kurland Date: Sat, 16 Aug 2008 03:15:39 +0000 Subject: [PATCH] bug 2051629 ] group with dns names are handled as empty --- doc/ChangeLog | 11 +++ src/ipt/ipt.cpp | 1 + test/ipt/objects-for-regression-tests.fwb | 111 +++++++++++++++++++--- 3 files changed, 111 insertions(+), 12 deletions(-) diff --git a/doc/ChangeLog b/doc/ChangeLog index dbfd1ae53..568e4fb4f 100644 --- a/doc/ChangeLog +++ b/doc/ChangeLog @@ -1,3 +1,14 @@ +2008-08-15 Vadim Kurland + + * Preprocessor.cpp (Preprocessor::isUsedByThisFirewall): fixed bug + #2051629: "group with dns names are handled as empty". This bug + triggered when object group that consisted of DNSName objects set + to resolve at compile time was used in policy rule and at the same + none of these DNSName objects were used in rules. If an object + from the group was itself used in a rule, compiler properly + converted it to address. But object was never used in rules by + itself, it was not converted. + 2008-08-14 Vadim Kurland * SSHUnx.cpp (SSHUnx::SSHUnx): fixed bug #2051005: "install to diff --git a/src/ipt/ipt.cpp b/src/ipt/ipt.cpp index 4a0c785d1..d8930c226 100644 --- a/src/ipt/ipt.cpp +++ b/src/ipt/ipt.cpp @@ -599,6 +599,7 @@ _("Dynamic interface %s should not have an IP address object attached to it. Thi Preprocessor* prep = new Preprocessor( objdb , fwobjectname, ipv6_policy); + if (test_mode) prep->setTestMode(); prep->compile(); diff --git a/test/ipt/objects-for-regression-tests.fwb b/test/ipt/objects-for-regression-tests.fwb index 605731814..07ac1d68a 100644 --- a/test/ipt/objects-for-regression-tests.fwb +++ b/test/ipt/objects-for-regression-tests.fwb @@ -1,6 +1,6 @@ - + @@ -596,7 +596,10 @@ - + + + + @@ -615,6 +618,10 @@ + + + + @@ -704,9 +711,9 @@ - - - + + + @@ -719,9 +726,9 @@ - - - + + + @@ -17532,7 +17539,7 @@ echo '%FWBPROMPT%'; sh /tmp/%FWSCRIPT% - + @@ -25487,9 +25494,9 @@ echo '%FWBPROMPT%'; sh /tmp/%FWSCRIPT% - + - + @@ -25510,7 +25517,47 @@ echo '%FWBPROMPT%'; sh /tmp/%FWSCRIPT% - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -25893,6 +25940,46 @@ echo '%FWBPROMPT%'; sh /tmp/%FWSCRIPT% + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +